Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version timeline #116

Closed
mohamed82008 opened this issue Oct 12, 2023 · 11 comments
Closed

New version timeline #116

mohamed82008 opened this issue Oct 12, 2023 · 11 comments

Comments

@mohamed82008
Copy link
Member

The current master branch is already in a better shape that the last release. What do you all think of making a new release now and then doing another (breaking) release later if needed?

@pkofod
Copy link

pkofod commented Oct 12, 2023

I tried adding support in NLSolvers using an extension, but only forwarddiff seemed to work all the way through. Master does work though, so I'm in favor!

@gdalle
Copy link
Member

gdalle commented Oct 12, 2023

I wanted to solve #53 before, since it's a very breaking change

@gdalle
Copy link
Member

gdalle commented Oct 12, 2023

On it now

@devmotion
Copy link
Member

Based on the previous discussion in #53, this might require a few more design discussions though. I wonder if we should make a breaking release now. And not rush the tuple issue but instead take the time (a few days? at most two weeks, I guess?) to discuss and come up with a consistent and satisfying solution. And then make another breaking release.

@gdalle
Copy link
Member

gdalle commented Oct 12, 2023

Fine with that too

@gdalle
Copy link
Member

gdalle commented Oct 12, 2023

#117

@mohamed82008
Copy link
Member Author

Thanks @gdalle and @devmotion, closing this issue now.

@gdalle
Copy link
Member

gdalle commented Oct 12, 2023

@gdalle gdalle reopened this Oct 12, 2023
@gdalle
Copy link
Member

gdalle commented Oct 12, 2023

The stable docs wasn't built, probably because the CI was configured back when there was no docs website. I tried pushing a new tag but to no avail.
I thought the push syntax included tags as workflow triggers, but perhaps we need to specify that explcitly?

@ToucheSir
Copy link

ToucheSir commented Oct 14, 2023

but perhaps we need to specify that explcitly?

Yes, see e.g. https://github.com/JuliaCI/PkgTemplates.jl/blob/v0.7.45/.github/workflows/CI.yml#L8.

@gdalle
Copy link
Member

gdalle commented Oct 16, 2023

Working now

@gdalle gdalle closed this as completed Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants