Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and test mangling #632

Merged
merged 7 commits into from
Sep 25, 2024
Merged

Fix and test mangling #632

merged 7 commits into from
Sep 25, 2024

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Sep 25, 2024

I was finally fed up with some complex signatures not rendering nicely in the profiler, but it took a couple of hours to squash all the bugs. We can now successfully mangle the following:

julia> GPUCompiler.mangle_sig(Tuple{GPUArrays.var"#35#37", CUDA.CuKernelContext, CuDeviceMatrix{Float32, 1}, Base.Broadcast.Broadcasted{CUDA.CuArrayStyle{2, CUDA.DeviceMemory}, Tuple{Base.OneTo{Int64}, Base.OneTo{Int64}}, typeof(Base.literal_pow), Tuple{CUDA.CuRefValue{typeof(^)}, Base.Broadcast.Extruded{CuDeviceMatrix{Float32, 1}, Tuple{Bool, Bool}, Tuple{Int64, Int64}}, CUDA.CuRefValue{Val{2}}}}, Int64})
"_Z3_3515CuKernelContext13CuDeviceArrayI7Float32Li2ELi1EE11BroadcastedI12CuArrayStyleILi2E12DeviceMemoryE5TupleI5OneToI5Int64ESA_E11literal_powS7_I10CuRefValueI1_E8ExtrudedIS2_S7_I4BoolSH_ES7_IS9_S9_EESD_I3ValILi2EEEEES9_"

shell> c++filt _Z3_3515CuKernelContext13CuDeviceArrayI7Float32Li2ELi1EE11BroadcastedI12CuArrayStyleILi2E12DeviceMemoryE5TupleI5OneToI5Int64ESA_E11literal_powS7_I10CuRefValueI1_E8ExtrudedIS2_S7_I4BoolSH_ES7_IS9_S9_EESD_I3ValILi2EEEEES9_
_35(CuKernelContext, CuDeviceArray<Float32, 2, 1>, Broadcasted<CuArrayStyle<2, DeviceMemory>, Tuple<OneTo<Int64>, OneTo<Int64> >, literal_pow, Tuple<CuRefValue<_>, Extruded<CuDeviceArray<Float32, 2, 1>, Tuple<Bool, Bool>, Tuple<Int64, Int64> >, CuRefValue<Val<2> > > >, Int64)

Includes tests based on demumble, a c++filt-like tool.

@maleadt
Copy link
Member Author

maleadt commented Sep 25, 2024

@pxl-th @jpsamaroo Is the AMDGPU.jl segfault here known?

@maleadt maleadt merged commit 316668b into master Sep 25, 2024
17 of 18 checks passed
@maleadt maleadt deleted the tb/mangling branch September 25, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant