Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should Base.keys(ds) default to varnames(ds) #25

Open
lupemba opened this issue Oct 8, 2024 · 1 comment
Open

Should Base.keys(ds) default to varnames(ds) #25

lupemba opened this issue Oct 8, 2024 · 1 comment

Comments

@lupemba
Copy link

lupemba commented Oct 8, 2024

Reading the documentation it looks like that varnames should be implemented for each AbstractDataset but my experience with MetopNative.jl is that CommonDataModel.jl relies more on Base.keys e.g. in the show method

varnames = keys(ds)

An easy fix for this could be to add varnames as the fallback method.

Base.keys(ds::AbstractDataset) = varnames(ds)

I might try to make a PR tomorrow.

@Alexander-Barth
Copy link
Member

Yes, that is a good idea! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants