export of "contains" conflicts with Base

[alex-s-gardner]

WARNING: both GeometryOps and Base export "contains"; uses of it in module Main must be qualified

[asinghvi17]

Ah, I usually use it as import GeometryOps as GO for exactly this reason. I guess we could stop exporting contains though.

[alex-s-gardner]

bumping this again as I continually run into this error:

Hint: It looks like two or more modules export different bindings with this name, resulting in ambiguity. Try explicitly importing it from a particular module, or qualifying the name with the module it should come from.
Hint: a global variable of this name also exists in Base.

[rafaqz]

Yeah we should stop exporting it, PR accepted ;)

[alex-s-gardner]

All GeometryOps methods are exported so I'm not sure how we want to deal with this. Do we just not export contains or does GO stop exporting all methods?

[rafaqz]

Just contains for now I think?

Ohhhh @asinghvi17 has that export loop. This is what I meant about it being hard for people to understand.

Explicitly exporting names is clearer

[alex-s-gardner]

#233

[asinghvi17]

The export loop was only in the Core PR and I think we dropped that anyway.. but thanks for the pr! Merging core will be a breaking release so we can do it with that