-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make reproject
safer across CRS
#205
Comments
@asinghvi17 what are you defining as a It would be nice if reproject had a |
Yeah that would be nice...the problem is, that we don't actually have access to valid bounds :D https://github.com/MakieOrg/GeoMakie.jl/blob/e897be2d7227e9b935efc0657276004f51fcd138/src/projection.jl#L37-L46 is what I use to handle this in GeoMakie, it could be useful here - but it does add a bit of time to the algorithm. |
What about returning an error along the lines of "some points fall outside of valid projection domain, try supplying a valid extent to clipsrc" |
If we just error by default but we let users pass an argument to get slower but correct/NaN results? |
Apparently it can error if your point is completely outside the valid area. Should we make it return:
?
cc @alex-s-gardner who brought this up on Slack
The text was updated successfully, but these errors were encountered: