Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid redundant calculations for geometries with constant Jacobian #107

Open
mikeingold opened this issue Oct 11, 2024 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@mikeingold
Copy link
Collaborator

Currently, integrals have to run jacobian at every point in the domain where the integrand function is evaluated. However, many geometries have linear parametric functions that will produce the exact same jacobian at every valid point in the geometry, making every function call after the first redundant.

Ideas:

  • Identify all geometry types that this applies to
  • Maybe create a special case single-argument jacobian(geometry) for these cases?
    • Map jacobian(geometry, ts) -> jacobian(geometry), or jacobian(geometry) -> jacobian(geometry, zeros(T, paramdim(geometry)))?
  • Use memoization to cache results?
  • Maybe create another set of _integral workers that dispatch on these cases and move the differential calculation outside the integral?
@mikeingold mikeingold added the enhancement New feature or request label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant