Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use eachvertex in more places #1137

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Use eachvertex in more places #1137

merged 1 commit into from
Nov 19, 2024

Conversation

juliohm
Copy link
Member

@juliohm juliohm commented Nov 19, 2024

Initial attempt to fix #1136

cc: @ghyatzo

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.73%. Comparing base (7e94faf) to head (03ac598).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
ext/grid.jl 0.00% 1 Missing ⚠️
ext/utils.jl 50.00% 1 Missing ⚠️
src/hulls.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1137   +/-   ##
=======================================
  Coverage   87.73%   87.73%           
=======================================
  Files         191      191           
  Lines        6016     6016           
=======================================
  Hits         5278     5278           
  Misses        738      738           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@juliohm juliohm marked this pull request as ready for review November 19, 2024 15:52
@juliohm juliohm merged commit d1d8ebe into master Nov 19, 2024
15 of 16 checks passed
@juliohm juliohm deleted the eachvertex-refactor branch November 19, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace vertices by eachvertex in algorithms when possible
2 participants