Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace vertices by eachvertex in algorithms when possible #1136

Closed
juliohm opened this issue Nov 18, 2024 · 2 comments · Fixed by #1137
Closed

Replace vertices by eachvertex in algorithms when possible #1136

juliohm opened this issue Nov 18, 2024 · 2 comments · Fixed by #1137
Labels
good first issue Good for newcomers help wanted Extra attention is needed performance

Comments

@juliohm
Copy link
Member

juliohm commented Nov 18, 2024

The latter is memory-efficient, and can lead to faster code.
@juliohm juliohm added help wanted Extra attention is needed good first issue Good for newcomers performance labels Nov 18, 2024
@juliohm
Copy link
Member Author

juliohm commented Nov 18, 2024

@ghyatzo this can be a fun exercise to get used to the code base in case you have time.

@ghyatzo
Copy link
Contributor

ghyatzo commented Nov 18, 2024

Sounds fun, I'll give a look during this week probably!

@juliohm juliohm mentioned this issue Nov 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use eachvertex in more places JuliaGeometry/Meshes.jl
2 participants
@juliohm @ghyatzo