Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for constructive geometry #251

Open
jondea opened this issue Mar 16, 2022 · 2 comments
Open

Support for constructive geometry #251

jondea opened this issue Mar 16, 2022 · 2 comments
Labels

Comments

@jondea
Copy link

jondea commented Mar 16, 2022

As part of a FEM project I have implemented an Annulus<:Primitive type and several related functions. Does this count as a primitive, as in there isn't some clever way to make it from two balls? And if not, is this something that would be welcome for a PR?

@juliohm
Copy link
Member

juliohm commented Mar 16, 2022

Hi @jondea thank you for proposing the primitive. I think what we really need is an API for constructive geometry. There are some packages out there already like

implementing subtraction, intersection and union of primitives. Ideally, we will be able to introduce these same operations in Meshes.jl reusing our primitive types to avoid inefficiencies with type conversion, and to help new users who just want to load a single ecosystem to get things done quickly.

@jondea
Copy link
Author

jondea commented Mar 16, 2022

Hi @juliohm, thank you for the pointers! That approach is certainly more elegant. I've made a branch with the Annulus type so I don't lose it https://github.com/jondea/Meshes.jl/tree/add-annulus-primitive, and I hope to be able to come back to this when I have more time.

@juliohm juliohm changed the title New primitive suggestion: annulus Support for constructive geometry Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants