Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label not supported with viz #551

Open
BloodWorkXGaming opened this issue Aug 7, 2023 · 3 comments
Open

Label not supported with viz #551

BloodWorkXGaming opened this issue Aug 7, 2023 · 3 comments
Labels
feature help wanted Extra attention is needed

Comments

@BloodWorkXGaming
Copy link

Hello :)

Trying to add a label to geometryobject (polyarea in this cade) isn't supported with the viz function.
It results in the following error:

ERROR: `legendelements` returned an empty list for content element of type MakieCore.Combined{Meshes.viz, Tuple{GeometrySet{2, Float64, PolyArea{2, Float64, Ring{2, Float64, CircularArrays.CircularVector{Point2, Vector{Point2}}}}}}}. That could mean that neither this object nor any possible child objects had a method for `legendelements` defined that returned a non-empty result.

I know it isn't supported from the documentation, but it's a seems like a useful feature I'd like to ask for :)
Thanks in advance!

@juliohm juliohm added help wanted Extra attention is needed good first issue Good for newcomers feature labels Aug 7, 2023
@juliohm
Copy link
Member

juliohm commented Aug 7, 2023

Thanks for the feature request @BloodWorkXGaming. If you can find the underlying Makie call in our recipes where this options should be inserted, that will help us speed up the impementation. Feel free to submit a PR as well.

@BloodWorkXGaming
Copy link
Author

Alright thanks :) will check it out in the next few days, quite low on time currently.

@juliohm
Copy link
Member

juliohm commented Nov 29, 2023

The goal here is to introduce a global label option to assign labels to elements of the domain.

@juliohm juliohm removed the good first issue Good for newcomers label Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants