Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.7? #112

Closed
dkarrasch opened this issue Nov 29, 2022 · 6 comments
Closed

Release v0.7? #112

dkarrasch opened this issue Nov 29, 2022 · 6 comments

Comments

@dkarrasch
Copy link
Contributor

Please, please consider releasing v0.7 very soon. The currently released state of the package can be viewed as nearly-broken. This is due to the many deprecation warnings. For instance, see JuliaLinearAlgebra/GenericLinearAlgebra.jl#91, whose CI was failing, because it couldn't finish its test suite within 5 hours. Usually, it takes just a handful of minutes. Essentially all of the 5 hours were spent on computing the QR decomposition of a 50x50 quaternion matrix. There, dot products of quaternion vectors are computed, and in every product of quaternions the package itself uses a quaternion constructor that is deprecated, so it's not even the "fault" of the downstream package. Releasing a new minor version should do no harm, because all downstream packages are stuck at v0.6.x by their Project.toml. Anyone who wants to upgrade will run CI and fix all issues that appear, so there shouldn't be any breakage in the ecosystem.

@sethaxen
Copy link
Collaborator

Thanks for pinging us, and yes, we should do this soon. @hyrodium is #108 the only thing missing before we can release?

@hyrodium
Copy link
Collaborator

#108 is the biggest change, but we also have #62 and #86. These two are not hard to fix.

@sethaxen
Copy link
Collaborator

I agree, all of these should be in the release. I'll finish up #108 today or tomorrow.

@sethaxen
Copy link
Collaborator

sethaxen commented Dec 1, 2022

@hyrodium I can also take removing all complex promotion to quaternion unless you've already started on it.

@hyrodium
Copy link
Collaborator

hyrodium commented Dec 1, 2022

Thanks for the suggestion! I opened #113 to remove complex promotions. I will update #95 and #111 today or tomorrow.

@hyrodium
Copy link
Collaborator

hyrodium commented Dec 7, 2022

The next version v0.7.0 will be released soon! JuliaRegistries/General#73647

@hyrodium hyrodium closed this as completed Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants