Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regarding from_image #5

Open
4 tasks
skariel opened this issue Oct 28, 2014 · 1 comment
Open
4 tasks

regarding from_image #5

skariel opened this issue Oct 28, 2014 · 1 comment

Comments

@skariel
Copy link
Contributor

skariel commented Oct 28, 2014

a few TODOs:

  • the .c.b thing needs to be configurable
  • npoints is not really the number of poits, just the number of trys. The actual number of points will depend on the actual image gray areas. I'll change this to actually mean the number of points
  • The 0.5 and 0.01 thesholds can be configurable too
  • Testing, once with a generated image (e.g. just white/black blocks or lines)
@skariel skariel mentioned this issue Feb 9, 2015
Merged
@amellnik
Copy link

Also the current README.md seems to imply that from_image should be exported, but it is not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@skariel @amellnik