Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute Treatments function #9

Open
Jay-sanjay opened this issue Mar 17, 2024 · 2 comments
Open

Execute Treatments function #9

Jay-sanjay opened this issue Mar 17, 2024 · 2 comments
Assignees
Labels
discussion Needs to be dicussed-designed throughly before implementing

Comments

@Jay-sanjay
Copy link
Member

This function will probably act as sewing function, that sews all the initially created functions and run a full Pathway synthesis, for a given database and event cohorts.

@Jay-sanjay Jay-sanjay added the discussion Needs to be dicussed-designed throughly before implementing label Mar 17, 2024
@Jay-sanjay Jay-sanjay self-assigned this Mar 17, 2024
@Jay-sanjay
Copy link
Member Author

Jay-sanjay commented Feb 5, 2025

@TheCedarPrince This function is supposed to do a sewing job to all the functions, For which this is the chain of functions execution, I am imagining as of now :
period_prior_to_index ---> calculate_era_duration ---> minPostCombinationDuration_filter ---> create_treatment_history --->EraCollapse ---> combination_Window .
Do let me know what are your thoughts and recommendations for the same !

@TheCedarPrince
Copy link
Member

Hey @Jay-sanjay , this sounds entirely reasonable to me. Can you try drafting a PR for this, testing it out and showing me the results, and then I can review? I think the approach makes sense but I would want to see it in action to add more comments/thoughts. Some other questions:

  1. What do you envision as the API?
  2. Should we enable logging or information of some kind?
  3. It may be nice to have the ability to pull out intermediate pieces from the processesing (i.e. pull out the durations, histories, etc.) so folks can audit each part of the execution.

Thanks Jay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Needs to be dicussed-designed throughly before implementing
Projects
None yet
Development

No branches or pull requests

2 participants