-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PackageCompiler fails nightly PkgEval (but nightly CI passes in this repo's GitHub Actions) #1020
Comments
Looking at the server now that the job has been running for close to 90 minutes, it doesn't seem stuck, just chugging along. Maybe it's slow because of enabling assertions in Julia? In any case, I don't want to extend the PkgEval time limits any further, even if it's only a single package exceeding them, the "tail latency" is large enough already (so testing PackageCompiler is likely to block the entire process while it's the only package being tested). |
Could we use a regular (non-assert) build of Julia when testing PackageCompiler in PkgEval? |
No, that's the kind of hacking around I want to avoid adding to PkgEval. |
We can make PackageCompiler.jl/test/runtests.jl Line 28 in 1c35331
be true on PkgEval? |
Doesn't that trigger already? We do set |
But that is not the only condition? |
Oh, sorry, I'm blind. Yeah, it's probably worth extending that to cover PkgEval. |
I don't know if this is a PkgEval bug or a PackageCompiler bug (or a Julia bug).
In PkgEval on
julia#master
, PackageCompiler times out, even if the timeout is really high. For example, this PkgEval job times out at 8181 seconds:8181 seconds = 2 hours 16 minutes. Here's the versioninfo for the aforementioned PkgEval job:
However, when I run PackageCompiler on GitHub Actions CI on Julia nightly, the job passes in 1 hour 27 minutes. See for example this recent nightly CI job on this repo:
Here is the versioninfo for the aforementioned GitHub Actions job:
It is unfortunate that PackageCompiler fails in nightly PkgEval, because it means we can't detect if/when something in upstream Julia breaks PkgEval.
@maleadt @KristofferC Any ideas?
The text was updated successfully, but these errors were encountered: