Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly import Bool and Integer before extending these #62

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Feb 17, 2025

These Base functions were being extended in the package, but they were not imported

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.16%. Comparing base (6e4e2dc) to head (6b628ad).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #62   +/-   ##
=======================================
  Coverage   98.16%   98.16%           
=======================================
  Files           6        6           
  Lines         218      218           
=======================================
  Hits          214      214           
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dlfivefifty dlfivefifty merged commit 9016953 into master Feb 17, 2025
11 checks passed
@jishnub jishnub deleted the jishnub/Base_imports branch February 17, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants