-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use of ProgressMeter.jl and added a reset_callback
to DPWSolver
#69
Merged
Merged
Changes from 5 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
c669087
Added DPWSolver parameter 'enable_state_pw' for explicit enabling of …
mossr 56080c4
Added 'reset_callback' option to DPWSolver
mossr 863a70a
ProgressMeter: added @showprogress around DPW simulate
mossr 2cc8cf7
Added `show_progress=false` kwarg to DWP action_info
mossr dd4f21f
Merge remote-tracking branch 'upstream/master'
mossr 98db9f5
Removed use of `isnothing` for Julia v1.0 compatibility
mossr 0a8ef3c
Ensure no performance degradation when not using ProgressMeter
mossr 9f810ab
Clarify use of `reset_callback`
mossr 3b48768
Merge remote-tracking branch 'upstream/master'
mossr e204118
Added DWP test for ProgressMeter and `reset_callback`
mossr c006ef2
Removed left-over progress `dt`
mossr 50673ba
Optimized out reset_callback, moved show_progress to solver, and call…
mossr bb6c6cb
Fixed `show_progress` test
mossr 844f055
Relax Colors lower bound version requirement
mossr a3e9c2b
put reset_callback into planner
zsunberg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,6 +8,7 @@ using POMDPSimulators | |
using CPUTime | ||
using Random | ||
using Printf | ||
using ProgressMeter | ||
|
||
export | ||
MCTSSolver, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest using an
Union{Progress, Nothing}
here. So that @zsunberg will have no concern about performance😁