detect_cxxstring_abi is unreliable when library includes std::map::erase[abi:cxx11] symbol

[topolarity]

Found this when I was working on Glibmm.

These symbols are incorrectly detected as evidence of a cxx11 string ABI by BinaryBuilder:

sandbox:${WORKSPACE}/srcdir/glibmm-2.66.6/builddir # nm /workspace/destdir/lib/libgiomm-2.4.so | c++filt | grep cxx11
00000000001617f4 t std::map<Glib::ustring, (anonymous namespace)::OptionArgCallbackData*, std::less<Glib::ustring>, std::allocator<std::pair<Glib::ustring const, (anonymous namespace)::OptionArgCallbackData*> > >::erase[abi:cxx11](std::_Rb_tree_iterator<std::pair<Glib::ustring const, (anonymous namespace)::OptionArgCallbackData*> >)
0000000000161ae4 t std::_Rb_tree<Glib::ustring, std::pair<Glib::ustring const, (anonymous namespace)::OptionArgCallbackData*>, std::_Select1st<std::pair<Glib::ustring const, (anonymous namespace)::OptionArgCallbackData*> >, std::less<Glib::ustring>, std::allocator<std::pair<Glib::ustring const, (anonymous namespace)::OptionArgCallbackData*> > >::erase[abi:cxx11](std::_Rb_tree_iterator<std::pair<Glib::ustring const, (anonymous namespace)::OptionArgCallbackData*> >)

There are probably others too.

[giordano]

That's coming from

BinaryBuilder.jl/src/auditor/compiler_abi.jl

Lines 203 to 208 in 673c93e

	# Shove the symbol names through c++filt (since we don't want to have to
	# reimplement the parsing logic in Julia). If anything has `cxx11` tags,
	# then mark it as such.
	if any(occursin("[abi:cxx11]", c) || occursin("std::__cxx11", c) for c in symbol_names)
	return "cxx11"
	end

So this criterion is inaccurate?