Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for #48 #50

Merged
merged 2 commits into from
Jul 16, 2018
Merged

Add test for #48 #50

merged 2 commits into from
Jul 16, 2018

Conversation

jmert
Copy link
Contributor

@jmert jmert commented Jul 12, 2018

Adds the tests related to issue #48 and the change made in #49.

I tried making sure these test fail when the change in #48 is reverted, but I couldn't get it to trigger. I don't know if I'm just invoking pkg> test Requires from the wrong environment (i.e. it's just pulling Requires v0.5.2 back in) or maybe there's a difference related to Pkg2 vs Pkg3 style environments — I was initially running into the bug for some code I was adding a Project.toml and trying to sort out how sub-projects should be structured... (See comments below.)

@jmert
Copy link
Contributor Author

jmert commented Jul 12, 2018

So it turns out I can trigger the error like in #48 by reverting #49 (but keeping the new tests) and then further substituting PyPlot in everywhere instead of JSON. (Is the difference potentially that I think JSON requires only stdlib packages whereas PyPlot needs other packages?)

@MikeInnes
Copy link
Collaborator

Yeah, that would likely make a difference. Would be good to find a simpler package than PyPlot that still has a dependency.

@jmert
Copy link
Contributor Author

jmert commented Jul 12, 2018

Switching to Colors which has a couple of dependencies doesn't trigger the error. 😕

Edit: Strike that; I only updated the submodule dependency, but it needs to be the @require-triggered package as well. That does fail now.

The tests need to load a package which itself has non-stdlib packages
as sub-dependencies for this to trigger load errors.
@MikeInnes MikeInnes merged commit 7e5bbdc into JuliaPackaging:master Jul 16, 2018
@MikeInnes
Copy link
Collaborator

👍 Thanks!

@jmert jmert deleted the test48 branch July 16, 2018 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants