You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In case you are loading a RDWaveform which consists of Integers, most filter code in RadiationDetectorDSP fails because it wants to return Int types for each sample after the filter is applied.
So far, we convert the waveforms by something like this:
wvfs =shift_waveform.(wvfs, 0.0)
There should be a more elegant solution than this.
First thing I would think of: limit the filters that require floating point precision to floating point precision
(<:AbstractFloat instead of <:Real, <:Union{<:AbstractFloat, Quantity{<:AbstractFloat}} instead of RealQuantity)
In case you are loading a
RDWaveform
which consists ofIntegers
, most filter code inRadiationDetectorDSP
fails because it wants to returnInt
types for each sample after the filter is applied.So far, we convert the waveforms by something like this:
There should be a more elegant solution than this.
CC @fhagemann
The text was updated successfully, but these errors were encountered: