-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BoundsError #12
Comments
That definitely looks like a bug... but hard to pinpoint without sample code. Can you build a simple testcase that causes this issue? You could generate sample data using something like:
Are you using multiple y for the same x? Are you using 2-dimensional x vectors? 2-dimensional y vectors? ...? |
Just a single 1 dimensional vector. I can't duplicate the issue with random data, but its reliable with my model output - which has a lot of very small numbers around zero in it, but other than that I have no idea whats going on. |
Thanks for that tidbit. It might be a bug with the algorithm for "F1 acceleration". You can disable F1 acceleration by adding the following to your
If you no longer get a bounds error, that is likely the cause. ...Sadly, disabling F1 acceleration reduces the plotting speed somewhat - especially with large datasets. |
Yep that fixed it, and slowed it down a bit... |
Great. That's good to know. The problem is in the The F1 acceleration algorithm is known not to be rock solid (see comment):
I am not exactly certain how to make this more robust yet. On hack you could try is to increase the size of the padding at the "end" of the undersampled vector:
Try increasing the value of 1 in this line to something larger... but I still don't feel this to be a real solution to the problem - just a band-aid. |
@rafaqz: BTW, I know disabling F1 acceleration slows things down significantly for large datasets (easily 2-10x for GBs of data)... but is it still faster than GR/plotly? Just curious. |
Update: Just added a failsafe that will fall back to plotting with naive solution if code for F1 acceleration crashes (no need for premature de-optimization with
|
Go ahead and try a |
I'm getting this error with some series lengths of large arrays, using InspectDR as a Plots.jl backend.
It doesn't occur with other backends, and seems to be occuring in InspectDR internals - my arrays are much larger than 1007 elements.
The text was updated successfully, but these errors were encountered: