-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: FNCFunctions v1.0.0 #122478
New package: FNCFunctions v1.0.0 #122478
Conversation
JuliaRegistrator
commented
Jan 6, 2025
- Registering package: FNCFunctions
- Repository: https://github.com/fncbook/FNCFunctions.jl
- Created by: @tobydriscoll
- Version: v1.0.0
- Commit: 0806d384614cfe717f683a3bea0adc3f7551660d
- Reviewed by: @tobydriscoll
- Reference: fncbook/FNCFunctions.jl@0806d38#commitcomment-150962510
- Release notes:
UUID: ab0dfefa-d313-416d-841c-e73335ae36c8 Repo: https://github.com/fncbook/FNCFunctions.jl.git Tree: f69605cde176d9aab963b2c01025758848edf351 Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human. 1. New package registrationPlease make sure that you have read the package naming guidelines. 2. AutoMerge Guidelines which are not met ❌
3. Needs action: here's what to do next
If you need help fixing the AutoMerge issues, or want your pull request to be manually merged instead, please post a comment explaining what you need help with or why you would like this pull request to be manually merged. Then, send a message to the 4. To pause or stop registrationIf you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text Tip: You can edit blocking comments to add |
Thank you for submitting your package! Please make sure the package is fully documented before registering. Especially for an initial version
For an initial version v0.1, the bar would be lower:
[noblock] |
If these are the official rules of General @goerz, please consider adding them to the README or to some other place in the docs – before asking to follow that from all users. Otherwise, the first part (specific to v1.0) sounds like a subjective set of preferences, not a registration requirement. Meanwhile, I of course agree with the remainder: name, non-trivialness, docs are the actual rules, already mentioned in the docs. [noblock] |
@aplavin They are not official rules, but I feel perfectly fine with leaving a blocking comment on registrations that do not meet what I consider reasonable standards. Any member of the community is free to do the same. None of it is a registration requirement. Any registry maintainer can override blocking comments. We really have almost no absolute, hard requirements for registration. Only guidelines, and I believe that all of my points are in the spirit of those guidelines. [noblock] |
I think I had not previously set up the repo to have its Pages site active.
The dev version of the docs is up now, and I have updated the README to
point to it and give some guidance.
This is an unusual package. It's purely meant for pedagogy, not scientific
work, as stated now in the README. The book is 95% complete and also found
via the README. It serves as the real documentation, which is why the
formal docs are pretty spartan. I hope that makes sense.
I'm not familiar with the code coverage tools, but all the functions are
tested and not too complex. Also, the textbook has 100+ demos that
thoroughly exercise them. It's been out for a few years now, too.
Thanks,
Toby
…---
Tobin Driscoll
Unidel Chaired Professor of Mathematical Sciences
Director, Master of Science program in Data Science
University of Delaware, Newark, DE 19716
On Mon, Jan 6, 2025 at 4:31 PM Michael Goerz ***@***.***> wrote:
@aplavin <https://github.com/aplavin> They are not official rules, but I
feel perfectly fine with leaving a blocking comment on registrations that
do not meet what I consider reasonable standards. Any member of the
community is free to do the same.
None of it is a registration *requirement*. Any registry maintainer can
override blocking comments. We really have almost no absolute, hard
requirements for registration. Only guidelines, and I believe that all of
my points are in the spirit of those guidelines.
—
Reply to this email directly, view it on GitHub
<#122478 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA3JNLVWHEEYUWLVSDHEUFL2JLY2VAVCNFSM6AAAAABUV3TK42VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZTHE3DCNZTHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@goerz it would be counterproductive if everyone wrote blocking comments with their personal preferences on how Julia packages are supposed to look. Say, I prefer package names consisting of no more than two words, and I leave a comment in every new registration that has 3 or more. IMO that is an unreasonable thing to do, and same with your 1.0 "rules". If you think they are actual widely-applicable recommendations, add them to General / AutoMerge guidelines! Following others' advice, I was considering starting all my new packages at 1.0 so that to have an extra version number just in case. The version number doesn't say anything universal really, aside from having 2 vs 3 numbers to play with. At least now I know that you intend to block all 1.0 registrations, and will just do 2.0.0 if I decide I need 3 numbers :) To @tobydriscoll: assuming you fix all other issues and the name is ok, you can either ask at Slack#pkg-registration to merge this, or register 0.1 and immediately bump to 1.0 after registration. [noblock] |
[noblock] @tobydriscoll Thanks for the updates and the explanation, that looks totally fine to me! I'll be happy to unblock my comment.
In general, "code coverage" is just keeping track of which lines get run during the tests (via a command line flag to Julia), and uploading it to Codecov (what most Julia packages use). The main reason to aim for a reasonably high percentage of covered lines in a v1.0 is that it provides a way to track if future changes are breaking. Without tests, it's very easy to accidentally introduce a breaking change inadvertently.
That depends on how unusual their personal preferences are. Insisting that v1.0 packages must define their API doesn't seem like something that should be overly controversial. As for the specific details of my "requirements", you should see those as a "working definition" that is absolutely open to negotiation. Which is also why I would be reluctant to nail that down in any official guidelines.
As far as your existing packages go, as far as I've seen, they have documentation and make SemVer guarantees about their API, so I think you should register a v1.0. For new registrations, I don't necessarily object to starting with v1.0, as long as they fully document their API.
I know you believe that, but it's just not true (if you're following the SemVer spec). But it's also beside the point: You like to treat v0.x versions as stable, which I don't think is a great idea, but it's not a violation of SemVer, and it's not that big of a deal. But in any case, that doesn't affect the semantics of a v1.0 version, which SemVer defines as the version that specifies the stable API. I'm just asking that packages tagged as v1.0 actually do that.
I have no such intention!
That's just being silly, and, of course, v2.0 has the same requirements as v1.0
Or, just engage with my comment, assuming good faith. These "requirements" are in no way hard rules. I'm more than happy to unblock after reaching common ground, as happened here. Asking on Slack from someone to override my (or anyone's) objections would only be necessary if the discussion does not reach a consensus.
Technically, yes, but that doesn't change the semantics of a v1.0 release. It's a bit unfortunate that there's no waiting period for v1.0 releases (something I might advocate for in the future). But yeah, if you're hell-bent on going out of your way to avoid defining an API for your v1.0 packages, or otherwise ignore the requirements of SemVer, that's ultimately between you and your users. There's only so much I can do to push people in the right direction. |
@goerz I know what code coverage is in general. I just don't know how to feel about a badge that says 65% coverage versus one that says 85%. For this application, it's not worth the hassle to me, so I am downgrading to v0.1.0. |
That wasn't really a strict requirement. If you are confident that you'll be able to know whether any future PR on your package will be breaking or not, I'm totally fine if you want to tag the initial version as [noblock] |
Closing in favor of #122529 You still have to fix the Julia compat issue, though |