Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base.view support #419

Open
iblislin opened this issue Jun 18, 2019 · 5 comments
Open

Base.view support #419

iblislin opened this issue Jun 18, 2019 · 5 comments

Comments

@iblislin
Copy link
Collaborator

iblislin commented Jun 18, 2019

@view ta[1:42]

to avoid allocation

@iblislin
Copy link
Collaborator Author

iblislin commented Jul 5, 2019

Maybe we need a new type for viewed TimeArray.

@jd-lara
Copy link

jd-lara commented Jul 25, 2019

Hi, is there an ETA on this functionality? We have integrated TimeSeries in our package, but when slicing data, there is too much memory allocation with respect to DataFrames. We would like to keep TimeArrays, but the performance hit is significant.

@iblislin
Copy link
Collaborator Author

Hi @jd-lara , no ETA at this moment. I can mark this issue as high priority in my mind. I still need to do some surveys about the implementation details of @view.

@jd-lara
Copy link

jd-lara commented Jul 26, 2019

Thanks, we will stick with TimeArrays for now and hopefully won't be too much of a bottleneck.

@iblislin
Copy link
Collaborator Author

I wrote some study notes here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants