fixes v0.7 warnings #85
Conversation
src/tzdata/archive.jl
Outdated
| @@ -1,6 +1,6 @@ | |||
| import Compat: @static, is_windows | |||
| import Compat: @static | |||
There was a problem hiding this comment.
You should import Sys from Compat for this to work on 0.6
src/adjusters.jl
Outdated
| @@ -5,10 +5,11 @@ import Base.Dates: firstdayofweek, lastdayofweek, firstdayofmonth, lastdayofmont | |||
|
|
|||
| # Truncation | |||
| # TODO: Just utilize floor code for truncation? | |||
| function trunc{P<:DatePeriod}(zdt::ZonedDateTime, ::Type{P}) | |||
|
|
|||
|
I made the requested changes. I do not know how to get them to be part of the active PR. |
src/local.jl
Outdated
| @@ -1,9 +1,9 @@ | |||
| # Determine the local system's time zone | |||
| # Based upon Python's tzlocal https://pypi.python.org/pypi/tzlocal | |||
| import Compat: @static, is_apple, is_unix, is_windows, readstring | |||
| import Compat: @static, readstring | |||
|
added missing () to Sys.iswindows (should fix checks) |
Codecov Report
@@ Coverage Diff @@
## master #85 +/- ##
==========================================
- Coverage 94.4% 57.51% -36.9%
==========================================
Files 26 26
Lines 948 1391 +443
==========================================
- Hits 895 800 -95
- Misses 53 591 +538
Continue to review full report at Codecov.
|
|
the current error in testing is on linux -- it is not finding the TZ environment variable set, |
|
I've squashed your changes and included them in #88. Ideally will be merging today if we can get the CI to cooperate. |
I may have got to all of them, maybe not -- the edits are unchecked, so there is the possibility of typos.
I understand that you have clients who need the v0.5 compat, so this should be given a separate tag and should go with code that gets a non-v0.5 compat version number