Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README Clarification #36

Open
damianoneill opened this issue Jan 2, 2018 · 3 comments · Fixed by #39
Open

README Clarification #36

damianoneill opened this issue Jan 2, 2018 · 3 comments · Fixed by #39

Comments

@damianoneill
Copy link
Contributor

I am unclear what is happening in each of the sections. Everything with a section header requires an explanation of what it’s doing when running the commands. This will require someone who understand this to complete, I can’t help with this.

For e.g. thing that should be described;

  • When I run ‘make generate’ what is being generated? Why are we generating? How will they be used?
  • What are the schema files, how are they used?
  • When I run ‘make test’ what is being tested, the generator, framework, use cases, etc?
  • What is the API server, when I start it what is it exposing? How can I confirm it started correctly? What endpoints are available?
  • The two command line tools that are shown, how are these built?
@nati nati self-assigned this Jan 2, 2018
nati added a commit that referenced this issue Jan 2, 2018
Closes #36

- fix typos
- fix server command
@nati nati mentioned this issue Jan 2, 2018
@nati nati closed this as completed in #39 Jan 3, 2018
@damianoneill
Copy link
Contributor Author

@nati the commit doesn't address all the issue above. I need textual descriptions in each of the sections for the Bullets listed above.

The problem is although I can execute each of the commands I dont understand why I am doing this or what happens when I do it.

For others who are not familiar with the code (myself included) we need to describe what this provides.

Does this make sense?

@damianoneill damianoneill reopened this Jan 3, 2018
@nati
Copy link
Contributor

nati commented Jan 8, 2018

Oh I thought the PR answered your questions because you approved it.
I believe I've updated README to answer your questions, so if current description isn't enough clear could you clarify your questions again?

@damianoneill
Copy link
Contributor Author

Sure @nati

The bullet points above, I'm looking for textual answers in each section. If it's easier maybe we could do a webex and you could walk me through the code, based on that I'll write up the descriptions? If this is an option, I'd like to extend the invite to others in the METc team?

Thanks,
Damian.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants