Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer: reset local_path for transfers where the file is no longer shared #207

Open
JurgenR opened this issue Mar 17, 2024 · 3 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@JurgenR
Copy link
Owner

JurgenR commented Mar 17, 2024

When an item is no longer shared but was previously requested the local_path of a transfer might still be set. This might cause the file still to be uploaded despite no longer wanting to share it.

If the shared item is removed from the shares:

  • Complete / Failed: should do nothing -> ensure local_path is cleared when item goes back in queue (although this should not be possible)
  • Uploading: not sure yet? Finish it or cancel?
  • Queued: remove the local_path, move to Failed?
@JurgenR JurgenR added the bug Something isn't working label Mar 17, 2024
@JurgenR JurgenR self-assigned this Mar 17, 2024
@JurgenR
Copy link
Owner Author

JurgenR commented Mar 17, 2024

I feel like the logic for state transitions could still be simplified, it seems like such odd situations keep occurring

@JurgenR
Copy link
Owner Author

JurgenR commented Mar 24, 2024

As part of this issue, also check what happens if the file has become locked for that user

@JurgenR
Copy link
Owner Author

JurgenR commented Mar 24, 2024

What might resolve issues is to simply check if the file is accessible when a PeerTransferQueue or PeerTransferRequest comes in and only set the local_path when the download or upload starts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant