Work with x.com #270
Open
Work with x.com #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fresh new way to do things. Won't work on my node 22 otherwise.
also add x.com, not just *.x.com, to manifest
|
The new commit address the issue where image-side display is too narrow to fit the full button: I simply choose to not emit the span if the available width is less than 2x the min-width of 165 px. (Honestly in my opinion it should always be the small version, because it just blends better with the bookmark & share buttons that way.) |
Otherwise it breaks on 1 reply. Thanks, elon, for once your addition helped.
|
So on the backend front, manually editing the link from x to twitter like so: https://webrecorder.github.io/save-tweet-now/#url=https%3A%2F%2Ftwitter.com%2Fdimaheve%2Fstatus%2F1844176938895802615&autoupload=1 still works, but it gets stuck at the "pinning to IPFS" step. Should I add this workaround, or wait for them to properly fix the thing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It doesn't work with x.com! Well it does now, if webrecorder/save-tweet-now#8 gets fixed. We are visiting the right URL, it's all the backend's fault.
Closes: #269
Checklist
Put an
xin the boxes that applyIf files added, I have modified bundle.sh and esbuild.js to ensure the new files are included in the packageI have added necessary documentation (if appropriate).Screenshots (Optional)
Concrete proof of it working. Somewhat.
Other information (Optional)
Any other information that is important to this pull request.