cxx-qt-lib: qdatetime put deprecated behind cfg flag #1109
+19
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahayzen-kdab
force-pushed
the
1106-remove-deprecated-methods
branch
2 times, most recently
from
c1f2146
to
50aabce
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1109 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 71 71
Lines 11949 11949
=========================================
Hits 11949 11949 ☔ View full report in Codecov by Sentry. |
TimeSpec methods have been deprecated. Closes KDAB#1106
ahayzen-kdab
force-pushed
the
1106-remove-deprecated-methods
branch
from
50aabce
to
ea252ff
Compare
ahayzen-kdab
commented
Oct 21, 2024
| @@ -56,10 +56,12 @@ mod ffi { | |||
| fn offsetFromUtc(self: &QDateTime) -> i32; | |||
There was a problem hiding this comment.
remaining issue appears to be with Qt 6.8 the linking order is incorrect with Qt6QuickControls2 being linked before our staticlib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1106