Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KOS vessel modules appear to be added to things that don't really need them #3118

Open
JonnyOThan opened this issue Aug 19, 2024 · 3 comments
Labels
enhancement Something new (not a bug fix) is being requested

Comments

@JonnyOThan
Copy link
Contributor

JonnyOThan commented Aug 19, 2024

flags, asteroids, probably debris...

Also uses FixedUpdate, there might be a better option?

@JonnyOThan JonnyOThan added the enhancement Something new (not a bug fix) is being requested label Aug 19, 2024
@Dunbaratu
Copy link
Member

Well, I mean technically a flag is a vessel, in the game's object hierarchy. I don't know (other than just hardcoding which class types to omit) what flag or criteria we could use to detect "this vessel isn't really a vessel. At least not that kind of vessel."

@JonnyOThan
Copy link
Contributor Author

JonnyOThan commented Aug 20, 2024

other than just hardcoding which class types to omit)

that’s probably where I’d start. There can be hundreds of asteroids, flags and debris in the universe and this can be a significant performance hit.

In fact..is the VesselModule only needed for loaded vessels? I’d assume it has some role to play in message handling but I didn’t see anything in a quick skim of the code.

@SofieBrink
Copy link
Contributor

The vessel class in KSP has a CurrentControlLevel property, You could probably simply exclude any vessel where this is ControlLevel.NONE to avoid hardcoding based on vessel types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something new (not a bug fix) is being requested
Projects
None yet
Development

No branches or pull requests

3 participants