Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Change how vessels in VPGs are tracked when not in focus #19

Open
Teykn opened this issue May 7, 2023 · 3 comments
Open

Request: Change how vessels in VPGs are tracked when not in focus #19

Teykn opened this issue May 7, 2023 · 3 comments

Comments

@Teykn
Copy link

Teykn commented May 7, 2023

Current behavior:
Parameters in VPGs with vessels are only tracked when the vessel is currently controlled by the player. This works fine for parameters which can be instantly completed and kept that way, such as having crew, but does not work fine for "progressive" parameters like the Duration parameter, as they do not progress when the vessel is not in focus.
VPGs with vessels tracked also seem to check the current vessel for the tracked vessel's parameters first, resulting in progressive parameters resetting and forcing the player to control the tracked vessel

Desired behavior:
Parameters in VPGs with vessels tracked keep their previous states when switching away, and don't get updated when the current vessel is not the tracked vessel.
Progressive parameters are able to track their progress while away from the tracked vessel, only resetting progress while in control of the vessel.

@siimav
Copy link

siimav commented May 20, 2023

I don't believe this is entirely true. For instance the duration parameter can get tracked for multiple simultaneous vessels without getting reset. Yes, the contract window will show the values for the last visited vessel but it will restore the state after returning to another one.
To be fair, many contracts in RP-1 were structured in a way where the duration always got reset after switching scenes or going to another vessel. This commit illustrates the changes needed to fix it: KSP-RO/RP-1@939a1a5

@Teykn
Copy link
Author

Teykn commented May 21, 2023

I tested the solution done in the commit. It does track across different vessels/scenes, but the way it is set up can cause it to activate earlier than intended. Contract I tested on is set up with 5 VPGs, with the Duration parameter in the 3rd VPG, and the 1st and 3rd focusing on the same vessel. Once VPG 1 is complete, it starts the Duration in VPG 3, even though I have it set so the duration is intended to start only when crew is present, which the vessel did not have.

@siimav
Copy link

siimav commented Dec 3, 2023

Yeah, the usage of All parameter as illustrated above appears to be a bad idea. Looks like with #29 we should go back to wrapping Duration inside Orbit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants