1.2 Update #1436

NathanKell · 2016-12-04T00:28:24Z

jwvanderbeck · 2016-12-04T01:41:06Z

Is anything needed of me for TF or do you guys got it?

PhineasFreak · 2016-12-04T09:50:30Z

Every RO part that utilizes a TACLS converter will need to be updated to the new "TacGenericConverter" module. Example follows.

Before:

MODULE
{
    name = TacGenericConverter
    converterName = CO2 Scrubber
    conversionRate = 4.0
    inputResources = CarbonDioxide, 0.0058912100, ElectricCharge, 0.010, LithiumHydroxide, 0.0000085683
    outputResources = Water, 0.0032924498, true, Waste, 0.0000257297, false
}

After:

MODULE
{
    name = TacGenericConverter
    converterName = CO2 Scrubber
    StartActionName = Start CO2 Scrubber
    StopActionName = Stop CO2 Scrubber
    tag = Life Support
    GeneratesHeat = False
    UseSpecialistBonus = True
    SpecialistEfficiencyFactor = 0.2
    SpecialistBonusBase = 0.05
    ExperienceEffect = ConverterSkill
    EfficiencyBonus = 1
    conversionRate = 4.0

    INPUT_RESOURCE
    {
        ResourceName = CarbonDioxide
        Ratio = 0.00589121
    }

    INPUT_RESOURCE
    {
        ResourceName = ElectricCharge
        Ratio = 0.01
    }

    INPUT_RESOURCE
    {
        ResourceName = LithiumHydroxide
        Ratio = 0.0000085683
    }

    OUTPUT_RESOURCE
    {
        ResourceName = Water
        Ratio = 0.0032924498
        DumpExcess = True
    }

    OUTPUT_RESOURCE
    {
        ResourceName = Waste
        Ratio = 0.0000257297
        DumpExcess = False
    }
}

stratochief66 · 2016-12-07T00:51:31Z

@jwvanderbeck I don't think we know right now. Probably not, but we'll now for sure once we've got RSS & RO rolling again :)

blowfishpro · 2016-12-08T02:18:08Z

I think all the important changes have been made in AJE and RF. @NathanKell I know you mentioned some improvements that could be made to the ullage code with KSP 1.2's resource flow changes, and I haven't looked at that.

lamont-granquist · 2016-12-08T21:39:28Z

RT has a KSP 1.2.1-compatible version available: https://github.com/RemoteTechnologiesGroup/RemoteTech/releases/tag/RemoteTech-1.8.2

NathanKell · 2016-12-09T04:48:22Z

Checked the ones that are either released or (RF) ready to be.

@jwvanderbeck as Strato says, sorry, dunno yet. :\

lamont-granquist · 2016-12-10T19:31:13Z

RT released 1.8.3 now which is 1.2.2 compatible: https://github.com/RemoteTechnologiesGroup/RemoteTech/releases/tag/1.8.3

stratochief66 · 2016-12-14T04:44:08Z

@lamont-granquist thanks for checking RT. I personally don't play with it, so I wouldn't know how to test it. Have you personally used it in 1.2.2, ideally with RSS?

lamont-granquist · 2016-12-14T17:18:42Z

@stratochief66 no, i'm not playing RSS in 1.2.2, shaving other yaks...

PhineasFreak · 2016-12-14T17:29:20Z

RT works, if i can say, better in KSP 1.2 than in KSP 1.1.3. There are some major bug fixes (like the science transmittion bug) that have been fixed and they were backported to the 1.1.3 version.

From the list:

RealHeat compiles and runs without any hitch or change from the previous release.
Same with AJE (although there might be some optimizations to do).
CBK has a 1.2 compatible release.
PF has been updated with a lot of goodies and bug fixes.
TestFlight has been updated by @linuxgurugamer but i have not tested it yet.

The rest of the mods need a rework.

RedAV8R · 2016-12-17T13:44:17Z

I know it's pretty minor, but PParts really could be updated to get that annoying popup to not popup. There will be people who continually say 'it's not updated', when while it works the popup shows says it's not. I've submitted a PR for it, though not entirely sure that's all that needs to happen.

blowfishpro · 2016-12-21T20:44:09Z

RF and AJE can be checked off now

RedAV8R · 2016-12-21T21:04:13Z

@NathanKell So RealHeat is checked off...is this now done internally with KSP or is there an actual updated version floating around somewhere?

@PhineasFreak

Some minor notes: numbers should now be properly formatted (0.01 vs 0.010), and booleans start with a capital (True vs true) This was done in response to the comment made by @PhineasFreak here: KSP-RO#1436

rsparkyc · 2017-01-03T21:43:14Z

pushed up a PR for TACLS, anything else that I can help with?

jwvanderbeck · 2017-01-04T22:44:13Z

For TestFlight: KSP-RO/TestFlight#154

jwvanderbeck · 2017-01-05T00:25:32Z

https://github.com/KSP-RO/TestFlight/releases/tag/1.8.0.0.beta-1

Needs to be tested

rsparkyc · 2017-01-09T20:57:02Z

Looks like there's a pre-release for DRE: https://github.com/Starwaster/DeadlyReentry/releases/tag/v7.5.0

PhineasFreak · 2017-01-11T10:37:56Z

Note for future reference: there have been some changes to SmokeScreen to add a new particle system (shuriken). Any RealPlume configs that do some patching using a "final" pass (i.e. zzRealPlume) will need to be updated:

Before:

@EFFECTS
{
    @Hydrolox-Lower
    {
        @MODEL_MULTI_PARTICLE_PERSIST[shockcone]
        {
            @localPosition = 0.0, 0.0, 0.0
        }
    }
}

After:

@EFFECTS
{
    @Hydrolox-Lower
    {
        @MODEL_MULTI_SHURIKEN_PERSIST[shockcone]
        {
            @localPosition = 0.0, 0.0, 0.0
        }
    }
}

None of the above are required right now but when RealPlume implements this then it will.

RealPlume PR implementing these changes (#26)

stratochief66 · 2017-01-11T16:04:42Z

@PhineasFreak do you know if there was a functional reason to change the node name? Will plumes require tweaking in size, shape, speed etc along with the new particle effect? If so, that makes sense to distinguish between old and new configs.

Is there any reason to not just run a script searching for PARICLE in plumes and changing it to SHURIKEN ?

If that would work, @rsparkyc is good with scripts :)

PhineasFreak · 2017-01-11T16:17:02Z

@stratochief66 i think that sarbian intends the new system to be a drop-in replacement without any required config changes.

The script solution would be ideal. I think that Nhawks also did it that way for his RealPlume PR (or did a Find/Replace in Notepad++).

blowfishpro · 2017-01-11T17:09:46Z

More info on MODEL_MULTI_SHURIKEN_PERSIST -
http://forum.kerbalspaceprogram.com/index.php?/topic/64987-121-smokescreen-270-extended-fx-plugin-dec-18th/&do=findComment&comment=2892140

It is intended to be a drop-in replacement, the main benefit being less memory allocation while playing (i.e. gc alloc). Additional optimization can be done by reducing particleCountLimit (which is a new field) but that is not necessary.

I have implemented this change in B9, and everything seems to be working as it did before. I think it's safe to implement in RF's RealPlume configs as well.

rsparkyc · 2017-01-11T18:54:05Z

Cool, I can run through those later and make the change.

EDIT: Just looked at the memory usage graph. This looks much better, and should help if people are experiencing stuttering (which I was a lot)

EDIT 2: ok, made a PR here: #1483 Note: this changes all instances of the text, and doesn't do any checks for zzRealPlume. I don't know if that will be necessary though, and am not in a place where I can test this easily yet. Taking a look at the PR from @Nhawks1717, he only leaves one instance of MODULE_MULTI_PARTICLE_PERSIST, and that's in FX-test.cfg, so I'm thinking this PR might be good enough.

diego-treitos · 2017-01-11T20:42:07Z

CLS released a version that claims to support 1.2: https://github.com/codepoetpbowden/ConnectedLivingSpace/releases/tag/1.2.4.0
Should it be marked as "done"?

stratochief66 · 2017-01-12T02:14:10Z

@diego-treitos Not until I or somebody else tests it in game (with an RO-ish modded install) thoroughly and reports back. :)

rsparkyc · 2017-01-12T16:43:03Z

Trying to test stuff, I see realheat is marked as done, but it looks like the latest version is still for 1.1.3 (https://github.com/KSP-RO/RealHeat/releases/tag/v4.3). Is there a 1.2.2 recompile somewhere, I should I do it myself?

PhineasFreak · 2017-01-12T16:57:57Z

@rsparkyc i have pushed an update for RealHeat to the official repository (KSP-RO/RealHeat#2). Seems like that a simple recompile does the job!

rsparkyc · 2017-01-12T20:26:06Z

Yeah, I'm an idiot, didn't think to look at open PRs

rsparkyc · 2017-01-12T21:36:56Z

for anyone interested, i'm going to track my testing progress in this spreadsheet: https://docs.google.com/spreadsheets/d/19_dhwSioZODCCtMFD0kZOtbmbg--ryoE0nzoWJL2cRc/edit?usp=sharing Right now i'm just trynig to get the "Mandatory" mods, along with RSS, and see what works. I'm linking to the git commits or releases for all the dependencies, along with any notes regarding them

raidernick · 2017-01-22T08:07:20Z

@PhineasFreak the thing is rcsfx DOES use a different plume. It has it's own fx file that needs to be defined per config. I did this in my own mod files, but just changing the name won't do anything. It would either have no plume, or you'd see the new fx plume over the old particles.

So basically if you do a check for modulercs* and the mod is using the new rcsfx module and you DON'T define the plume, it will be invisible.

ec429 · 2017-03-19T16:43:29Z

Is KSCSwitcher a listed RO dependency? It probably needs KSP-RO/KSCSwitcher#2 and a release.

jwvanderbeck · 2017-03-20T22:10:09Z

TestFlight is no longer pre-release
https://github.com/KSP-RO/TestFlight/releases/tag/1.8.0.0

PhineasFreak · 2017-03-31T15:50:41Z

Pinging the members for the RSSTimeDateFormatter. A removal of the "KSPUtil" reference and a recompile is all that is needed. I can also open a PR if you want.

jwvanderbeck · 2017-03-31T15:55:23Z

Pinging the members for the RSSTimeDateFormatter. A removal of the "KSPUtil" reference and a recompile is all that is needed. I can also open a PR if you want.

That is mine. If you can submit a PR to fix it that would be great otherwise I will look at it this weekend.

EDIT: Re-read what you said and realized it is real simple :p I'll try to sneak that in today while I am at work.

PhineasFreak · 2017-03-31T16:31:17Z

@jwvanderbeck Yep, i just forked the repo and i saw that the only thing required was a recompile. I had recompiled it locally when KSP 1.2.0 was originally released but i had forgotten that it did not require any changes to the code.

jwvanderbeck · 2017-03-31T16:55:09Z

Having some problems with Xamarin but will get it recompiled soon as I can.

eberkain · 2017-04-04T01:07:08Z

Consider MandatoryRCS mod in place of Persistant Rotation?

Theysen · 2017-04-05T11:47:39Z

Why? Dare to elaborate eberkain? Is Persistent Rotation out of development and not working in 1.2.2?

eberkain · 2017-04-05T21:30:13Z

No, Persistent Rotation is fine. I only suggested looking at what both mods offer and considering which one would be better to include. Didn't mean to make anyone mad.

Theysen · 2017-04-07T18:09:12Z

Who got mad? I just wanted to know if you knew more than I did and might enlighten me, that was without any mad connotation!

RedAV8R · 2017-04-08T13:26:29Z

Considering that RO basically nukes Reaction Wheels and makes it so that RCS is essentially required I see no reason to include Mandatory RCS.

RedAV8R · 2017-04-21T14:03:35Z

@jwvanderbeck @PhineasFreak Any luck on RSS Time Date Formatter?

PhineasFreak · 2017-04-21T14:43:04Z

@RedAV8R I think that @jwvanderbeck will handle the required recompile. I can also open a PR to do so if he is busy.

jwvanderbeck · 2017-04-21T14:49:17Z

The problem I had was that I couldn't get it to build. My Xamarin project was being stupid and kept insisting that .NET was missing and I couldn't fix it :( I spent like a day trying to figure out what was wrong (TF builds fine) but couldn't figure it out.

I'll try just wiping what I have and download it fresh from git and see if that works.

PhineasFreak · 2017-04-21T15:03:06Z

@jwvanderbeck No probs. I also remember that one time that Xamarin acted stupidly after an update and would refuse to compile any of the projects that i had. Proper head banging stuff!

It turned out that i had to uninstall and reinstall it in order for the required Microsoft Build Tools to also install correctly...

stratochief66 · 2017-04-21T20:04:59Z

Possibly unimportant, but I found that the previous version simply seems to work for me in KSP 1.2.2 ; maybe just needs a CKAN metadata change rather than recompile?

jwvanderbeck · 2017-04-21T20:55:03Z

https://github.com/KSP-RO/RSSTimeFormatter/releases/tag/1.1.0.0

lamont-granquist · 2017-04-23T22:23:14Z

RealHeat, ConnectedLivingSpaces and Deadly Reentry are all installable on 1.2.2 off of CKAN

ghost · 2017-05-22T19:45:07Z

The Ferram Aerospace Research (FAR) mod is updated and live!

stratochief66 · 2017-05-23T23:01:50Z

@NathanKell @pap1723 @rsparkyc @SirKeplan

So, all the pre-reqs for RO now appear to be available on CKAN now. Am I wrong?

Is RO ready to go for a full release? If no objects, I am thinking of making a release either tonight or tomorrow. Thoughts?

pap1723 · 2017-05-23T23:13:27Z

Both RO and RP-0?

NathanKell · 2017-05-23T23:16:56Z

RO yay! But I would say RO only?

…

On May 23, 2017 4:13 PM, "Pap" ***@***.***> wrote: Both RO and RP-0? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1436 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AE5-ItSYcjzSKDXytKcq9zgvfPW3txKjks5r82gXgaJpZM4LDdSi> .

Theysen · 2017-05-24T08:55:52Z

KCT is still in beta develop so that rules out RP-0 for official CKAN / release

Olympic1 · 2017-05-25T08:15:12Z

KCT is still in beta develop so that rules out RP-0 for official CKAN / release

KCT is listed as a recommendation.

PhineasFreak · 2017-05-26T06:55:46Z

@Olympic1 this should probably be changed to a dependency, as RP-0 pretty much requires it for a balanced career gameplay.

Theysen · 2017-05-26T14:34:45Z

oh and RE: CLS - I didn't run into any issues with the latest 1.2.2 release.

Olympic1 · 2017-05-27T06:43:47Z

KCT just released for KSP 1.2. That makes all dependencies available for RP-0

NathanKell · 2017-06-05T18:33:48Z

Released

rsparkyc mentioned this issue Jan 3, 2017

Took a stab and performing the format conversion for TACLS #1468

Merged

NathanKell closed this as completed Jun 5, 2017

1.2 Update #1436

1.2 Update #1436

Comments

NathanKell commented Dec 4, 2016 • edited Loading

jwvanderbeck commented Dec 4, 2016

PhineasFreak commented Dec 4, 2016 • edited Loading

stratochief66 commented Dec 7, 2016

blowfishpro commented Dec 8, 2016

lamont-granquist commented Dec 8, 2016

NathanKell commented Dec 9, 2016

lamont-granquist commented Dec 10, 2016

stratochief66 commented Dec 14, 2016

lamont-granquist commented Dec 14, 2016

PhineasFreak commented Dec 14, 2016

RedAV8R commented Dec 17, 2016

blowfishpro commented Dec 21, 2016

RedAV8R commented Dec 21, 2016 • edited Loading

rsparkyc commented Jan 3, 2017

jwvanderbeck commented Jan 4, 2017

jwvanderbeck commented Jan 5, 2017

rsparkyc commented Jan 9, 2017

PhineasFreak commented Jan 11, 2017 • edited Loading

stratochief66 commented Jan 11, 2017

PhineasFreak commented Jan 11, 2017 • edited Loading

blowfishpro commented Jan 11, 2017

rsparkyc commented Jan 11, 2017 • edited Loading

diego-treitos commented Jan 11, 2017

stratochief66 commented Jan 12, 2017

rsparkyc commented Jan 12, 2017

PhineasFreak commented Jan 12, 2017

rsparkyc commented Jan 12, 2017

rsparkyc commented Jan 12, 2017 • edited Loading

raidernick commented Jan 22, 2017 • edited Loading

ec429 commented Mar 19, 2017

jwvanderbeck commented Mar 20, 2017 • edited Loading

PhineasFreak commented Mar 31, 2017

jwvanderbeck commented Mar 31, 2017 • edited Loading

PhineasFreak commented Mar 31, 2017

jwvanderbeck commented Mar 31, 2017

eberkain commented Apr 4, 2017

Theysen commented Apr 5, 2017

eberkain commented Apr 5, 2017

Theysen commented Apr 7, 2017

RedAV8R commented Apr 8, 2017

RedAV8R commented Apr 21, 2017

PhineasFreak commented Apr 21, 2017

jwvanderbeck commented Apr 21, 2017

PhineasFreak commented Apr 21, 2017

stratochief66 commented Apr 21, 2017

jwvanderbeck commented Apr 21, 2017

lamont-granquist commented Apr 23, 2017

ghost commented May 22, 2017 • edited by ghost Loading

stratochief66 commented May 23, 2017

pap1723 commented May 23, 2017

NathanKell commented May 23, 2017 via email

Theysen commented May 24, 2017

Olympic1 commented May 25, 2017

PhineasFreak commented May 26, 2017

Theysen commented May 26, 2017

Olympic1 commented May 27, 2017

NathanKell commented Jun 5, 2017

NathanKell commented Dec 4, 2016 •

edited

Loading

PhineasFreak commented Dec 4, 2016 •

edited

Loading

RedAV8R commented Dec 21, 2016 •

edited

Loading

PhineasFreak commented Jan 11, 2017 •

edited

Loading

PhineasFreak commented Jan 11, 2017 •

edited

Loading

rsparkyc commented Jan 11, 2017 •

edited

Loading

rsparkyc commented Jan 12, 2017 •

edited

Loading

raidernick commented Jan 22, 2017 •

edited

Loading

jwvanderbeck commented Mar 20, 2017 •

edited

Loading

jwvanderbeck commented Mar 31, 2017 •

edited

Loading

ghost commented May 22, 2017 •

edited by ghost

Loading