Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI fails due to missing dependency: kaszanas/sc2infoextractorgo #29

Closed
Ostrzyciel opened this issue Mar 28, 2024 · 3 comments
Closed

CI fails due to missing dependency: kaszanas/sc2infoextractorgo #29

Ostrzyciel opened this issue Mar 28, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@Ostrzyciel
Copy link
Collaborator

Currently the CI will fail on trying to pull the kaszanas/sc2infoextractorgo image, which it uses as a dependency. See for example here: https://github.com/Kaszanas/SC2DatasetPreparator/actions/runs/8467611697/job/23198781862

It seems that these images are not published anywhere. As there is no release with a Linux version of the executable, I can't easily circumvent this. To make the CI here usable we would have to either:

  • a) implement Docker image building and publishing in sc2infoextractorgo for Docker Hub
  • b) same, but with GitHub Container Registry (would be easier than Docker Hub)
  • c) publish a Linux release and bodget it – instead of pulling the image, just run wget

In any case, I'd prioritize this, because the CI is otherwise useless.

@Ostrzyciel Ostrzyciel added the bug Something isn't working label Mar 28, 2024
@Kaszanas
Copy link
Owner

Kaszanas commented Mar 28, 2024

Yeah that's an issue for sure, I'm actively working on new release of the Golang piece of code which causes this issue.

It's worth noting that only one of the tools depends on sc2infoextractorgo. That being sc2_replaypack_processor

It would be safe to state that the main Dockerfile inheriting from a non existing image can be ommited for the sake of verifying all of the other tools in the meantime.

I will try to push a docker image matching the version that was used to build the original dataset do this issue will be alleviated.

But I am quite sure that there will be done changes to that one sc2_replaypack_processor especially because some Golang flags have evolved.

@Kaszanas
Copy link
Owner

Okay @Ostrzyciel I have went and made up the missing pieces for you:
https://hub.docker.com/repository/docker/kaszanas/sc2infoextractorgo/general

I have made it by checking out the 1.2.1 tag which was the original release, patching in a workflow_dispatch manual trigger for building a docker image and running it.

My guess is that everything should be operational. I will experiment with building Docker images later. for separate dev, main, and release tags.

@Ostrzyciel
Copy link
Collaborator Author

Yup, now it works, after a few more fixes. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants