Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Kdyby/Translation optional #29

Open
enumag opened this issue Oct 2, 2016 · 0 comments
Open

Make Kdyby/Translation optional #29

enumag opened this issue Oct 2, 2016 · 0 comments

Comments

@enumag
Copy link
Member

enumag commented Oct 2, 2016

Currently Kdyby/Validator requires Kdyby/Translation which doesn't work at all without HttpExtension and SessionExtension. Since there is no reason why Validator should require SessionExtension we should break the chain somewhere.

In my opinion we should remove the dependency on Kdyby/Translation from this package. Someone might want to replace it with some lighter integration of symfony/translation (it's on my todo list).

@fprochazka What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant