Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ks-email-parser python update #74

Open
7 of 12 tasks
b1r3k opened this issue Oct 1, 2024 · 0 comments · May be fixed by #75
Open
7 of 12 tasks

ks-email-parser python update #74

b1r3k opened this issue Oct 1, 2024 · 0 comments · May be fixed by #75
Assignees
@b1r3k

Comments

@b1r3k
Copy link
Contributor

b1r3k commented Oct 1, 2024 •
edited
Loading

lxml fails on 3.11 if lxml < 4
lxml >= 3 works

  1. find . -iname '.py' -not -path "/venv/*" -exec pyupgrade --py311-plus {} +
  2. transition to nose2
  3. enum changed behaviour of str()
  4. remove dependency on async_test
  5. transition to pytest - https://github.com/pytest-dev/nose2pytest
  6. update travis CI
  • what about different CI system?
    • github actions?
    • circle CI? (we already use it on mobile side)
  1. ansible playbook update
  2. Optional: transition to pyproject.toml
  3. Optional: aiohttp update?

requires: https://github.com/KeepSafe/email-service/issues/419

Findings

  • lxml 3.x does not compile on python 3.11 (at least when using python distribution provided by pyenv). lxml >= 4 compiles fine but tests may require some adjustment (output diff could have been caused by beautifulsoup in fact)
@b1r3k b1r3k self-assigned this Oct 7, 2024
@b1r3k b1r3k linked a pull request Oct 8, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@b1r3k b1r3k

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore python upgrade KeepSafe/ks-email-parser
1 participant
@b1r3k