Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into non-generic overloads for creating ops & non-generic JsonPatchDoc #64

Open
KevinDockx opened this issue Jan 19, 2017 · 3 comments

Comments

@KevinDockx
Copy link
Owner

Might conflict with JsonPatch.Dynamic?

cfr KevinDockx/JsonPatch.Dynamic#10 (comment)

@HappyNomad
Copy link

The two non-generic JsonPatchDocument classes would be in different namespaces, so the "conflict" is manageable.

@KevinDockx
Copy link
Owner Author

Yep, but the thing is that we'd end up with two classes that are copies of each other but just live in a different namespace - and that's not right. The best way to solve this from a design POV would be to move the non-generic JsonPatchDoc to this lib, and remove it from JsonPatch.Dynamic altogether, but that means a breaking change in JsonPatch.Dynamic. That could be mitigated by marking it as obsolete in JsonPatch.Dynamic (and remove it altogether later on) - what do you think?

@HappyNomad
Copy link

That approach sounds fine to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants