Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macro delays not working over bluetooth #290

Open
2 tasks
mvbentes opened this issue Aug 2, 2024 · 4 comments
Open
2 tasks

Macro delays not working over bluetooth #290

mvbentes opened this issue Aug 2, 2024 · 4 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@mvbentes
Copy link

mvbentes commented Aug 2, 2024

Describe the Bug

I have a macro configured that works just fine over cable connection, but gets corrupted over bluetooth.
I just made a simpler proof of concept and the bug holds.
The simpler macro is as follows:
{+KC_D}{-KC_D}{4000}{+KC_J}{-KC_J}
Over cable it correctly outputs dj with proper timing, but over bluetooth it seems like the first key remains pressed for the duration of the delay, outputing:
dddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddj

Keyboard Used

K13 Pro ISO RGB

Link to product page (if applicable)

https://www.keychron.com/products/keychron-k13-pro-qmk-via-wireless-custom-mechanical-keyboard-iso-layout-collection?variant=40558857322585

Operating System

Windows

qmk doctor Output

Not relevant. I am not compiling from qmk. I am using launcher.keychron.com

Is AutoHotKey / Karabiner installed

  • AutoHotKey (Windows)
  • Karabiner (macOS)

Other keyboard-related software installed

No response

Additional Context

I have already updated firmware to the latest version 1.0.1

I can not compile my own version of qmk firmware to test if that would solve the issue because source code for K13 Pro ISO was not released, as already requested on #289

@mvbentes mvbentes added bug Something isn't working help wanted Extra attention is needed labels Aug 2, 2024
@lokher
Copy link
Member

lokher commented Aug 20, 2024

Please try this firmware
keychron_k13_pro_iso_rgb_via.zip

@PeterMortensen
Copy link

PeterMortensen commented Aug 22, 2024

Re "I can not compile my own version of QMK firmware to test if that would solve the issue because source code for K13 Pro ISO was not released": Yeah, version 1.0.1 for K13 Pro ISO RGB has a release date of 2024-01-26 (perhaps depending on the exact source of it).

The 2024-03-30 change (EBA583) positively fixes a problem that prevents Via macros from being used in Bluetooth mode.

The source code has been released in the meantime

The source code for the two ISO variants of the K13 Pro has now been released (2024-08-19). Together with source code for the ISO variants of K11 Max and K5 Max. And source code for Q14 Max, Q15 Max, Lemokey P1 Pro, and V8 Max (at about the same time).

@mvbentes
Copy link
Author

I just tested the firmware @lokher provided and it solved the macro timing issue. Thank you very much!
To anyone also interested, the firmware provided here is not the same as the one launcher.keychron offers as upgrade. That one was last updated july 2024.

I have not had the opportunity to test compiling from the now published source. I hope to have the time to do it, since I also wanted to adjust the timing of the mod tap function.

Best regards!

@mvbentes
Copy link
Author

Hi, @lokher!

I am having a different problem with this firmware you sent. I am having a LOT more unwanted activation on my mod-tap key, to the point where I am considering deactivating it.

Was there any change to the timing limit in this version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants