diff --git a/.changeset/gorgeous-dragons-collect.md b/.changeset/gorgeous-dragons-collect.md new file mode 100644 index 0000000000..9645d22f69 --- /dev/null +++ b/.changeset/gorgeous-dragons-collect.md @@ -0,0 +1,5 @@ +--- +"@khanacademy/perseus-linter": patch +--- + +[Linter] Remove Math Font Size rule from editor linter diff --git a/packages/perseus-linter/src/__tests__/rules.test.ts b/packages/perseus-linter/src/__tests__/rules.test.ts index fd775fdfd7..5b05f1e5c7 100644 --- a/packages/perseus-linter/src/__tests__/rules.test.ts +++ b/packages/perseus-linter/src/__tests__/rules.test.ts @@ -20,7 +20,6 @@ import mathAdjacentRule from "../rules/math-adjacent"; import mathAlignExtraBreakRule from "../rules/math-align-extra-break"; import mathAlignLinebreaksRule from "../rules/math-align-linebreaks"; import mathEmptyRule from "../rules/math-empty"; -import mathFontSizeRule from "../rules/math-font-size"; import mathFracRule from "../rules/math-frac"; import mathNestedRule from "../rules/math-nested"; import mathStartsWithSpaceRule from "../rules/math-starts-with-space"; @@ -375,22 +374,6 @@ describe("Individual lint rules tests", () => { // @ts-expect-error - TS2554 - Expected 3 arguments, but got 2. expectPass(mathNestedRule, ["$\\text{4}x$", "inline $\\text{4}x$ math"]); - // @ts-expect-error - TS2554 - Expected 3 arguments, but got 2. - expectWarning(mathFontSizeRule, [ - "$\\tiny{x}$", - "inline $\\Tiny{x}$ math", - "$a \\small{x} b$", - "$\\large{ xyz }$", - "$ \\Large { x } $", - "$\\LARGE{x}$", - "$\\huge{x}$", - "$\\Huge{x}$", - "$\\normalsize{x}$", - "$\\scriptsize{x}$", - ]); - // @ts-expect-error - TS2554 - Expected 3 arguments, but got 2. - expectPass(mathFontSizeRule, ["$\\sqrt{x}$", "inline $\\sqrt{x}$ math"]); - // @ts-expect-error - TS2554 - Expected 3 arguments, but got 2. expectWarning(mathWithoutDollarsRule, [ "One half: \\frac{1}{2}!", diff --git a/packages/perseus-linter/src/rules/all-rules.ts b/packages/perseus-linter/src/rules/all-rules.ts index 148ff660b7..e05e18d314 100644 --- a/packages/perseus-linter/src/rules/all-rules.ts +++ b/packages/perseus-linter/src/rules/all-rules.ts @@ -24,7 +24,6 @@ import MathAdjacent from "./math-adjacent"; import MathAlignExtraBreak from "./math-align-extra-break"; import MathAlignLinebreaks from "./math-align-linebreaks"; import MathEmpty from "./math-empty"; -import MathFontSize from "./math-font-size"; import MathFrac from "./math-frac"; import MathNested from "./math-nested"; import MathStartsWithSpace from "./math-starts-with-space"; @@ -56,7 +55,6 @@ export default [ MathAlignExtraBreak, MathAlignLinebreaks, MathEmpty, - MathFontSize, MathFrac, MathNested, MathStartsWithSpace, diff --git a/packages/perseus-linter/src/rules/math-font-size.ts b/packages/perseus-linter/src/rules/math-font-size.ts deleted file mode 100644 index 84b62d1bb9..0000000000 --- a/packages/perseus-linter/src/rules/math-font-size.ts +++ /dev/null @@ -1,11 +0,0 @@ -import Rule from "../rule"; - -export default Rule.makeRule({ - name: "math-font-size", - severity: Rule.Severity.GUIDELINE, - selector: "math, blockMath", - pattern: - /\\(tiny|Tiny|small|large|Large|LARGE|huge|Huge|scriptsize|normalsize)\s*{/, - message: `Math font size: -Don't change the default font size with \\Large{} or similar commands`, -}) as Rule;