-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of new nested SVGs and Tick Labels for Interactive Graph to solve Safari rendering issues. #1452
Merged
Merged
Changes from 26 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
0fb7393
Testing prototype of new SVG axis tick labels + clipping mask
SonicScrewdriver 331d985
Updating prototype for Safari testing
SonicScrewdriver f3f1bc3
Updating prototype to solve a couple small bugs before recording demo
SonicScrewdriver cdb2d4b
wip
SonicScrewdriver 4c802a2
You put the svg in the svg and you line it all up
SonicScrewdriver 034e2b3
Solved ALL of the clipping mask issues!
SonicScrewdriver ae564a9
Added more edge cases, and started refactoring. Everything appears to…
SonicScrewdriver f86a725
Committing stories
SonicScrewdriver 5c05560
Clean up!
SonicScrewdriver cfdc26b
Refactoring + cleanup
SonicScrewdriver b915554
Tidying up comment errors
SonicScrewdriver a1e668a
Fixing "magic numbers" as much as possible
SonicScrewdriver cab392f
Fussing about comments
SonicScrewdriver d06b55c
Removing old tests
SonicScrewdriver 97048f4
Cleaning up storybook + css comment
SonicScrewdriver e572d62
Fixing minor negative 1 bug as we still want the tick
SonicScrewdriver 71f449a
Adding a test for a simple function
SonicScrewdriver a6b7bd7
Fixing weird editor save bugs + renaming function
SonicScrewdriver 88f0b47
Fixing PR to fully use X/Y and MIN/MAX
SonicScrewdriver c90b86c
Clean up + Fixing Safari Zoom bug + using KaTeX font
SonicScrewdriver b9e6109
Adjusting spacing as KaTeX seems to have a shorter xHeight
SonicScrewdriver eb4f90c
Cleanup + Added tests
SonicScrewdriver bc5f425
Retested SVG w/ CSS + minor visual improvements
SonicScrewdriver 8d82012
Clean up storybook
SonicScrewdriver 98ec076
[Locked Labels] Make a mafs sandwich so that labels can have backgrounds
nishasy e89727e
Revert "[Locked Labels] Make a mafs sandwich so that labels can have …
nishasy 2b2e503
fallback fonts
SonicScrewdriver File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@khanacademy/perseus": minor | ||
--- | ||
|
||
Implementation of SVG-based Axis Tick Labels for Interactive Graph |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58 changes: 0 additions & 58 deletions
58
packages/perseus/src/widgets/interactive-graphs/backgrounds/axis-tick-labels.test.ts
This file was deleted.
Oops, something went wrong.
301 changes: 0 additions & 301 deletions
301
packages/perseus/src/widgets/interactive-graphs/backgrounds/axis-tick-labels.tsx
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This file is no longer necessary, as we're pairing the ticks and labels back together within the SVG. |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is no longer needed, as the labels were able to be reintegrated with the axis-ticks themselves.