[Interactive Graph] Remove legacy graph #2228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (2e399cc) and published it to npm. You Example: yarn add @khanacademy/perseus@PR2228If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR2228 |
|
Size Change: -12.6 kB (-0.85%) Total Size: 1.47 MB
ℹ️ View Unchanged
|
nishasy
commented
Feb 11, 2025
|
|
||
| return ( | ||
| <div | ||
| className="graphie-container blank-background" |
There was a problem hiding this comment.
We can't get rid of these less styles yet because they're still being used in the Grapher widget.
| // (LEMS-2190): Move the Mafs Angle Graph coordinate reversal logic in interactive-graph-state.ts | ||
| // to this file when we remove the legacy graph. This logic allows us to support bi-directional angles | ||
| // for the new (non-reflexive) Mafs graphs, while maintaining the same scoring behaviour as the legacy graph. | ||
| // Once the legacy graph is removed, we should move this logic directly into the validate function below. |
There was a problem hiding this comment.
This ticket just got done a couple days ago! This comment just got missed and is cleared to be removed.
Merged
catandthemachines
added a commit
that referenced
this pull request
Feb 14, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/[email protected] ### Major Changes - [#2234](#2234) [`1ade12c18`](1ade12c) Thanks [@handeyeco](https://github.com/handeyeco)! - Move splitters into perseus-core, add splitPerseusItem ### Minor Changes - [#2228](#2228) [`edd34241e`](edd3424) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph] Remove legacy graph - [#2238](#2238) [`8e4cb7f53`](8e4cb7f) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - Bugfixes to ensure that focus is handled correctly on unlimited point/polygon graphs. ### Patch Changes - [#2223](#2223) [`f8a4becb0`](f8a4bec) Thanks [@mark-fitzgerald](https://github.com/mark-fitzgerald)! - [Bugfix] Interactive Graph crashes in editor when setting domain for locked function - [#2201](#2201) [`91cede41f`](91cede4) Thanks [@nishasy](https://github.com/nishasy)! - [SR] Refactor - Update graphs to pass in i18n context - [#2230](#2230) [`5fd3aa351`](5fd3aa3) Thanks [@nishasy](https://github.com/nishasy)! - [SR] Add screen reader support for pi-based numbers - [#2224](#2224) [`639eb089d`](639eb08) Thanks [@nishasy](https://github.com/nishasy)! - [SR] Add minimal instructions for how to interact with graph - [#2205](#2205) [`ae29e2b2f`](ae29e2b) Thanks [@catandthemachines](https://github.com/catandthemachines)! - Updating perseus analytics and events for better metrics. - [#2232](#2232) [`dc9989893`](dc99898) Thanks [@beaesguerra](https://github.com/beaesguerra)! - Tooling: Enabled jsx-a11y lint rules and disabled existing errors that were found - [#2229](#2229) [`91cd0c937`](91cd0c9) Thanks [@nishasy](https://github.com/nishasy)! - [SR] Sinusoid - add screen reader support - [#2236](#2236) [`df75123e5`](df75123) Thanks [@nishasy](https://github.com/nishasy)! - [LX] Add hairlines when Circle center has focus - [#2243](#2243) [`43005350f`](4300535) Thanks [@nishasy](https://github.com/nishasy)! - [SR] Angle - Update strings to reflect changes to SRUX specs - [#2245](#2245) [`037aaa2f4`](037aaa2) Thanks [@catandthemachines](https://github.com/catandthemachines)! - fixing bug in getWidgetSubTypeByWidgetId function. - [#2213](#2213) [`db9bc4fb6`](db9bc4f) Thanks [@nishasy](https://github.com/nishasy)! - [SR] Angle - Add the "interactive elements" overall graph description - [#2212](#2212) [`3ec6ec179`](3ec6ec1) Thanks [@nishasy](https://github.com/nishasy)! - [LX] Add hairlines when point has focus - [#2235](#2235) [`ab2041897`](ab20418) Thanks [@benchristel](https://github.com/benchristel)! - Remove unused code, and export the `ParseFailureDetail` type from `@khanacademy/perseus-core` - [#2221](#2221) [`71329fe35`](71329fe) Thanks [@nishasy](https://github.com/nishasy)! - [SR] Add aria-labels for x- and y-axis labels - [#2244](#2244) [`c565e26d4`](c565e26) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph] Replace string-based function call with switch statement - Updated dependencies \[[`f8a4becb0`](f8a4bec), [`ae29e2b2f`](ae29e2b), [`dc9989893`](dc99898), [`ab2041897`](ab20418), [`1ade12c18`](1ade12c), [`ce320b496`](ce320b4)]: - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Minor Changes - [#2235](#2235) [`ab2041897`](ab20418) Thanks [@benchristel](https://github.com/benchristel)! - Remove unused code, and export the `ParseFailureDetail` type from `@khanacademy/perseus-core` - [#2234](#2234) [`1ade12c18`](1ade12c) Thanks [@handeyeco](https://github.com/handeyeco)! - Move splitters into perseus-core, add splitPerseusItem ### Patch Changes - [#2223](#2223) [`f8a4becb0`](f8a4bec) Thanks [@mark-fitzgerald](https://github.com/mark-fitzgerald)! - [Bugfix] Interactive Graph crashes in editor when setting domain for locked function - [#2205](#2205) [`ae29e2b2f`](ae29e2b) Thanks [@catandthemachines](https://github.com/catandthemachines)! - Updating perseus analytics and events for better metrics. - [#2227](#2227) [`ce320b496`](ce320b4) Thanks [@benchristel](https://github.com/benchristel)! - Bugfix: Accept 'scientific' as a buttonSets value when parsing Expression widgets ## @khanacademy/[email protected] ### Patch Changes - Updated dependencies \[[`f8a4becb0`](f8a4bec), [`ae29e2b2f`](ae29e2b), [`ab2041897`](ab20418), [`1ade12c18`](1ade12c), [`ce320b496`](ce320b4)]: - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Patch Changes - Updated dependencies \[[`f8a4becb0`](f8a4bec), [`ae29e2b2f`](ae29e2b), [`ab2041897`](ab20418), [`1ade12c18`](1ade12c), [`ce320b496`](ce320b4)]: - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Patch Changes - Updated dependencies \[[`f8a4becb0`](f8a4bec), [`ae29e2b2f`](ae29e2b), [`ab2041897`](ab20418), [`1ade12c18`](1ade12c), [`ce320b496`](ce320b4)]: - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Patch Changes - [#2232](#2232) [`dc9989893`](dc99898) Thanks [@beaesguerra](https://github.com/beaesguerra)! - Tooling: Enabled jsx-a11y lint rules and disabled existing errors that were found - [#2235](#2235) [`ab2041897`](ab20418) Thanks [@benchristel](https://github.com/benchristel)! - Remove unused code, and export the `ParseFailureDetail` type from `@khanacademy/perseus-core` - Updated dependencies \[[`f8a4becb0`](f8a4bec), [`ae29e2b2f`](ae29e2b), [`ab2041897`](ab20418), [`1ade12c18`](1ade12c), [`ce320b496`](ce320b4)]: - @khanacademy/[email protected] - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Patch Changes - [#2223](#2223) [`f8a4becb0`](f8a4bec) Thanks [@mark-fitzgerald](https://github.com/mark-fitzgerald)! - [Bugfix] Interactive Graph crashes in editor when setting domain for locked function - [#2230](#2230) [`5fd3aa351`](5fd3aa3) Thanks [@nishasy](https://github.com/nishasy)! - [SR] Add screen reader support for pi-based numbers - [#2232](#2232) [`dc9989893`](dc99898) Thanks [@beaesguerra](https://github.com/beaesguerra)! - Tooling: Enabled jsx-a11y lint rules and disabled existing errors that were found - [#2229](#2229) [`91cd0c937`](91cd0c9) Thanks [@nishasy](https://github.com/nishasy)! - [SR] Sinusoid - add screen reader support - [#2235](#2235) [`ab2041897`](ab20418) Thanks [@benchristel](https://github.com/benchristel)! - Remove unused code, and export the `ParseFailureDetail` type from `@khanacademy/perseus-core` - [#2244](#2244) [`c565e26d4`](c565e26) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph] Replace string-based function call with switch statement - Updated dependencies \[[`f8a4becb0`](f8a4bec), [`91cede41f`](91cede4), [`5fd3aa351`](5fd3aa3), [`639eb089d`](639eb08), [`edd34241e`](edd3424), [`ae29e2b2f`](ae29e2b), [`dc9989893`](dc99898), [`91cd0c937`](91cd0c9), [`df75123e5`](df75123), [`43005350f`](4300535), [`037aaa2f4`](037aaa2), [`db9bc4fb6`](db9bc4f), [`3ec6ec179`](3ec6ec1), [`8e4cb7f53`](8e4cb7f), [`ab2041897`](ab20418), [`1ade12c18`](1ade12c), [`71329fe35`](71329fe), [`c565e26d4`](c565e26), [`ce320b496`](ce320b4)]: - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Patch Changes - [#2235](#2235) [`ab2041897`](ab20418) Thanks [@benchristel](https://github.com/benchristel)! - Remove unused code, and export the `ParseFailureDetail` type from `@khanacademy/perseus-core` - Updated dependencies \[[`f8a4becb0`](f8a4bec), [`ae29e2b2f`](ae29e2b), [`ab2041897`](ab20418), [`1ade12c18`](1ade12c), [`ce320b496`](ce320b4)]: - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Patch Changes - [#2235](#2235) [`ab2041897`](ab20418) Thanks [@benchristel](https://github.com/benchristel)! - Remove unused code, and export the `ParseFailureDetail` type from `@khanacademy/perseus-core` - Updated dependencies \[[`f8a4becb0`](f8a4bec), [`ae29e2b2f`](ae29e2b), [`ab2041897`](ab20418), [`1ade12c18`](1ade12c), [`ce320b496`](ce320b4)]: - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Patch Changes - Updated dependencies \[[`f8a4becb0`](f8a4bec), [`ae29e2b2f`](ae29e2b), [`ab2041897`](ab20418), [`1ade12c18`](1ade12c), [`ce320b496`](ce320b4)]: - @khanacademy/[email protected] - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Patch Changes - Updated dependencies \[[`f8a4becb0`](f8a4bec), [`ae29e2b2f`](ae29e2b), [`ab2041897`](ab20418), [`1ade12c18`](1ade12c), [`ce320b496`](ce320b4)]: - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Patch Changes - [#2235](#2235) [`ab2041897`](ab20418) Thanks [@benchristel](https://github.com/benchristel)! - Remove unused code, and export the `ParseFailureDetail` type from `@khanacademy/perseus-core` - Updated dependencies \[[`f8a4becb0`](f8a4bec), [`ae29e2b2f`](ae29e2b), [`dc9989893`](dc99898), [`ab2041897`](ab20418), [`1ade12c18`](1ade12c), [`ce320b496`](ce320b4)]: - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected]
|
Such an exciting milestone! 🌮 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The code has been updated and released for a while, and the flags have been removed!
We can officially remove the legacy graph code.
Issue: https://khanacademy.atlassian.net/browse/LEMS-2202
Test plan:
yarn jestyarn lintyarn typecheck