Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Interactive Graph] Remove legacy graph #2228

Merged
merged 4 commits into from
Feb 13, 2025
Merged

[Interactive Graph] Remove legacy graph #2228

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b6bb275
[remove-legacy-graph] Remove legacy graph
nishasy Feb 11, 2025
6dfa563
[remove-legacy-graph] docs(changeset): [Interactive Graph] Remove leg…
nishasy Feb 11, 2025
5ede5d9
[remove-legacy-graph] Destroy node_modules and update snapshots again
nishasy Feb 11, 2025
2e399cc
[remove-legacy-graph] Merge branch 'main' into remove-legacy-graph
nishasy Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fast-eyes-battle.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@khanacademy/perseus": minor
---

[Interactive Graph] Remove legacy graph
14 changes: 7 additions & 7 deletions packages/perseus/src/__tests__/__snapshots__/renderer.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,7 @@ exports[`renderer snapshots correct answer: correct answer 1`] = `
aria-haspopup="listbox"
aria-invalid="false"
aria-label="Test ARIA label"
class="button_vr44p2-o_O-shared_u51dsh-o_O-default_13mg2xx"
class="button_vr44p2-o_O-shared_u51dsh-o_O-default_3ie67y"
id=":r3:"
role="combobox"
type="button"
Expand All @@ -396,7 +396,7 @@ exports[`renderer snapshots correct answer: correct answer 1`] = `
</span>
<span
aria-hidden="true"
class="svg_1q6jc65-o_O-icon_wnyn4t-o_O-caret_ntkmq-o_O-inlineStyles_u7ovp6"
class="svg_1q6jc65-o_O-icon_eocf2p-o_O-caret_ntkmq-o_O-inlineStyles_u7ovp6"
/>
</button>
</div>
Expand Down Expand Up @@ -463,7 +463,7 @@ exports[`renderer snapshots incorrect answer: incorrect answer 1`] = `
aria-haspopup="listbox"
aria-invalid="false"
aria-label="Test ARIA label"
class="button_vr44p2-o_O-shared_u51dsh-o_O-default_13mg2xx"
class="button_vr44p2-o_O-shared_u51dsh-o_O-default_3ie67y"
id=":r6:"
role="combobox"
type="button"
Expand All @@ -488,7 +488,7 @@ exports[`renderer snapshots incorrect answer: incorrect answer 1`] = `
</span>
<span
aria-hidden="true"
class="svg_1q6jc65-o_O-icon_wnyn4t-o_O-caret_ntkmq-o_O-inlineStyles_u7ovp6"
class="svg_1q6jc65-o_O-icon_eocf2p-o_O-caret_ntkmq-o_O-inlineStyles_u7ovp6"
/>
</button>
</div>
Expand Down Expand Up @@ -555,7 +555,7 @@ exports[`renderer snapshots initial render: initial render 1`] = `
aria-haspopup="listbox"
aria-invalid="false"
aria-label="Test ARIA label"
class="button_vr44p2-o_O-shared_u51dsh-o_O-default_13mg2xx"
class="button_vr44p2-o_O-shared_u51dsh-o_O-default_3ie67y"
id=":r0:"
role="combobox"
type="button"
Expand All @@ -580,7 +580,7 @@ exports[`renderer snapshots initial render: initial render 1`] = `
</span>
<span
aria-hidden="true"
class="svg_1q6jc65-o_O-icon_wnyn4t-o_O-caret_ntkmq-o_O-inlineStyles_u7ovp6"
class="svg_1q6jc65-o_O-icon_eocf2p-o_O-caret_ntkmq-o_O-inlineStyles_u7ovp6"
/>
</button>
</div>
Expand Down Expand Up @@ -635,7 +635,7 @@ exports[`renderer snapshots renders a placeholder for a deprecated widget: depre
>
<span
aria-label="info"
class="svg_1q6jc65-o_O-icon_1521uiv-o_O-icon_gcwxx2-o_O-inlineStyles_94g682"
class="svg_1q6jc65-o_O-icon_1521uiv-o_O-icon_16tp01m-o_O-inlineStyles_94g682"
data-testid="banner-kind-icon"
role="img"
/>
Expand Down
2 changes: 1 addition & 1 deletion packages/perseus/src/__tests__/__snapshots__/server-item-renderer.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ exports[`server item renderer should snapshot: initial render 1`] = `
aria-invalid="false"
aria-label="Mock Widget"
aria-required="false"
class="input_1ck1z8k-o_O-LabelMedium_1rew30o-o_O-default_1tc7wjm-o_O-defaultFocus_lrnqlz"
class="input_1ck1z8k-o_O-LabelMedium_1rew30o-o_O-default_53h0n9-o_O-defaultFocus_9n1kv3"
id="mock-widget 1"
role="textbox"
type="text"
Expand Down
1 change: 0 additions & 1 deletion packages/perseus/src/components.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
export {default as ButtonGroup} from "./components/button-group";
export {default as Graph} from "./components/graph";
export {default as Graphie} from "./components/graphie";
export {default as HUD} from "./components/hud";
export {default as Icon} from "./components/icon";
Expand Down
22 changes: 0 additions & 22 deletions packages/perseus/src/components/__stories__/graph.stories.tsx
View file
Open in desktop

This file was deleted.

Loading
Loading