From 5d4b51b4f23ad1e0b94f14264833f5e62eb1e389 Mon Sep 17 00:00:00 2001 From: joshqti <127994991+joshqti@users.noreply.github.com> Date: Tue, 5 Nov 2024 10:11:52 -0800 Subject: [PATCH] vulkan: Remove redundant negative testing (#2078) - negative testing for semaphore functions is accomplished in semaphore tests, as well as create image in the api test Co-authored-by: dcrawley --- .../test_vulkan_api_consistency_for_1dimages.cpp | 10 ---------- .../test_vulkan_api_consistency_for_3dimages.cpp | 10 ---------- 2 files changed, 20 deletions(-) diff --git a/test_conformance/vulkan/test_vulkan_api_consistency_for_1dimages.cpp b/test_conformance/vulkan/test_vulkan_api_consistency_for_1dimages.cpp index 2df210081c..aefdb41457 100644 --- a/test_conformance/vulkan/test_vulkan_api_consistency_for_1dimages.cpp +++ b/test_conformance/vulkan/test_vulkan_api_consistency_for_1dimages.cpp @@ -158,16 +158,6 @@ int test_consistency_external_for_1dimage(cl_device_id deviceID, test_error(errNum, "Unable to create Image with Properties"); image.reset(); - // Passing properties, image_desc and image_format all as NULL - image = clCreateImageWithProperties(context, NULL, CL_MEM_READ_WRITE, NULL, - NULL, NULL, &errNum); - test_failure_error( - errNum, CL_INVALID_IMAGE_DESCRIPTOR, - "Image creation must fail with CL_INVALID_IMAGE_DESCRIPTOR " - "when all are passed as NULL"); - - image.reset(); - // Passing NULL properties and a valid image_format and image_desc image = clCreateImageWithProperties(context, NULL, CL_MEM_READ_WRITE, diff --git a/test_conformance/vulkan/test_vulkan_api_consistency_for_3dimages.cpp b/test_conformance/vulkan/test_vulkan_api_consistency_for_3dimages.cpp index f8a7861cec..a71fb9453d 100644 --- a/test_conformance/vulkan/test_vulkan_api_consistency_for_3dimages.cpp +++ b/test_conformance/vulkan/test_vulkan_api_consistency_for_3dimages.cpp @@ -162,16 +162,6 @@ int test_consistency_external_for_3dimage(cl_device_id deviceID, test_error(errNum, "Unable to create Image with Properties"); image.reset(); - // Passing properties, image_desc and image_format all as NULL - image = clCreateImageWithProperties(context, NULL, CL_MEM_READ_WRITE, NULL, - NULL, NULL, &errNum); - test_failure_error( - errNum, CL_INVALID_IMAGE_DESCRIPTOR, - "Image creation must fail with CL_INVALID_IMAGE_DESCRIPTOR " - "when all are passed as NULL"); - - image.reset(); - // Passing NULL properties and a valid image_format and image_desc image = clCreateImageWithProperties(context, NULL, CL_MEM_READ_WRITE,