Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable or delete dead code in test_external_semaphore.cpp #2109

Open
shajder opened this issue Oct 10, 2024 · 1 comment
Open

Re-enable or delete dead code in test_external_semaphore.cpp #2109

shajder opened this issue Oct 10, 2024 · 1 comment

Comments

@shajder
Copy link
Contributor

shajder commented Oct 10, 2024

While working on issue #1989 I've noticed in test_external_semaphore.cpp there is a function named test_external_semaphores_simple_2 which is not scheduled for test. Should this be removed or re-enabled?
@joshqti
Copy link
Contributor

joshqti commented Oct 21, 2024

After reviewing and testing, I don't see any harm in enabling it. I have pushed a PR to enable it and delete some other dead code.

#2123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shajder @joshqti