Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translator incapable to generate TypeStruct EntryPoint parameters #2510

Open
MrSidims opened this issue Apr 18, 2024 · 0 comments
Open

Translator incapable to generate TypeStruct EntryPoint parameters #2510

MrSidims opened this issue Apr 18, 2024 · 0 comments

Comments

@MrSidims
Copy link
Contributor

clang following spir calling convention will generate byval pointer on a kernel if a structure is passed as kernel argument, see https://godbolt.org/z/c994q86xr .

Translator generates SPIR-V following input LLVM IR 1:1 and also generates byval pointer. Meanwhile in SPIR-V it's not disallowed to use directly TypeStruct EntryPoint parameter, and in some cases it's a missing optimization opportunity.

Need to investigate if we can promote byval pointer and if it breaks anything end-2-end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant