Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.3.229 SDK makes non-backward-compatible change to SwapchainKHR::getImages() #1417

Open
azonenberg opened this issue Sep 26, 2022 · 0 comments

Comments

@azonenberg
Copy link

azonenberg commented Sep 26, 2022

The 1.3.224 and older SDK returns a std::vector<VkImage>.

6fe966c changes this to return a std::vector<vk::Image>. While vk::Image is directly convertible to VkImage, vector<vk::Image> and vector<VkImage> are not directly convertible.

As a result, existing code which assigns the value of getImages() to a variable of type vector<VkImage> will no longer compile with the .229 SDK, and changing the type will make it require .229 and not compile with .224 or older. This doesn't seem like the kind of API change that should have been made in a minor version.

I'm not sure what the best course of action is now that there's been an official SDK release containing this change, but I wanted to get it out there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant