Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Shader Object version of Undefined Value check #9435

Open
spencer-lunarg opened this issue Feb 14, 2025 · 1 comment
Open

Add Shader Object version of Undefined Value check #9435

spencer-lunarg opened this issue Feb 14, 2025 · 1 comment
Assignees
@ziga-lunarg
Labels
Incomplete Missing Validation VUs to be added

Comments

@spencer-lunarg
Copy link
Contributor

@ziga-lunarg pointed out in https://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/9425/files the test was wrong

  1. It is not invalid to do what we were doing (https://gitlab.khronos.org/vulkan/vulkan/-/issues/4186)
  2. We have tests for this "Undefined Value" warning in NegativeShaderInterface.CreatePipelineFragmentOutputNotConsumed
  3. (the issue) I realize we don't do that warning check with Shader Object. The code is in ValidateFsOutputsAgainstRenderPass/ValidateFsOutputsAgainstDynamicRenderingRenderPass and we could probably pipe those same 2 functions in the Shader Object path (and duplicate shader object version of those warnings)
@spencer-lunarg spencer-lunarg added the Incomplete Missing Validation VUs to be added label Feb 14, 2025
@ziga-lunarg
Copy link
Contributor

This is dependent on #7923

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ziga-lunarg ziga-lunarg

Labels
Incomplete Missing Validation VUs to be added
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ziga-lunarg @spencer-lunarg