New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test invalid parameter indices for OES_draw_buffers_indexed #3711

Merged

kenrussell merged 1 commit into KhronosGroup:main from lexaknyazev:dbi-invalid-values

Feb 13, 2025

Member

lexaknyazev commented Feb 6, 2025

The new test cases pass in Firefox but fail in Chromium and WebKit: they return zeros or falses instead of nulls.


          Test invalid parameter indices for OES_draw_buffers_indexed

95deaaf

lexaknyazev requested review from kenrussell and kkinnunen-apple

February 6, 2025 22:44

kkinnunen-apple approved these changes

View reviewed changes

kenrussell approved these changes

View reviewed changes

Member

kenrussell left a comment

Thanks for expanding the tests; looks good to me.

kenrussell merged commit c000377 into KhronosGroup:main

2 checks passed

lexaknyazev deleted the dbi-invalid-values branch

February 13, 2025 19:46

aarongable pushed a commit to chromium/chromium that referenced this pull request


          Validate index for OES_draw_buffers_indexed queries.

541a4d0

index can be pre-validated and synthetic errors can be generated in the
client instead of doing a round-trip and returning zeroes.

Tests coming in KhronosGroup/WebGL#3711

Bug: 396465061
Change-Id: Id00e147c43d90157e77506cd258eab5197b33b1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6264872
Commit-Queue: Geoff Lang <[email protected]>
Reviewed-by: Kenneth Russell <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1422007}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet