Add edit flow for Helix #5394
Open
Add edit flow for Helix #5394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
@franknoirot @jtran @nadr0 Alright adding you guys for review a little early here cause there are a few not-so-pretty things in this code but I'd like your input before spending too much time on it alone! But outside of these small-ish things this was super easy to implement to way to go on laying out the groundwork for people to run on it 👟 |
pierremtb
commented
Feb 14, 2025
| return baseCommand | ||
| } | ||
|
|
||
| // TODO: find a way to loop over the arguments while keeping it safe |
There was a problem hiding this comment.
Input welcome here. Lots of arguments here. 4 kcl, 2 options
pierremtb
commented
Feb 14, 2025
| operation.labeledArgs.axis.sourceRange[0], | ||
| operation.labeledArgs.axis.sourceRange[1] | ||
| ) | ||
| .replaceAll("'", '') // TODO: fix this crap |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5392