-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow VolView to be hosted at non-root url #690
Comments
I have been running the build with a CLI arg to configure a base path. But I like your change so that it just works without special config. |
PaulHax
added a commit
to PaulHax/VolView
that referenced
this issue
Jan 27, 2025
I'm open to this change! |
PaulHax
added a commit
to PaulHax/VolView
that referenced
this issue
Jan 28, 2025
Closes Kitware#690 Co-authored-by: amazy <[email protected]>
PaulHax
added a commit
to PaulHax/VolView
that referenced
this issue
Jan 28, 2025
Closes Kitware#690 Co-authored-by: @amazy <[email protected]>
Great ! Thanks for merging the change ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
When packaging VolView in the Orthanc plugin, Orthanc serves VolView at http://localhost:8042/volview/.
In order for this to work, we actually need to patch VolView code with the below patch.
The way we patch it, VolView can then actually be hosted at any url (because it is actually quite often served at something like https://myserver.com/orthanc/volview/).
Could ease our life for future releases if you allow hosting at any url and might be useful for other people too. Or maybe we are wrong and there is already a configuration for this !
Thanks,
Alain.
The text was updated successfully, but these errors were encountered: