Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make base path relative #694

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Conversation

PaulHax
Copy link
Collaborator

@PaulHax PaulHax commented Jan 28, 2025

Closes #690

@PaulHax PaulHax requested a review from floryst January 28, 2025 15:23
Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for volview-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 1832c17
🔍 Latest deploy log https://app.netlify.com/sites/volview-dev/deploys/679932707b21010008cbe8a8
😎 Deploy Preview https://deploy-preview-694--volview-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@floryst floryst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would recommend also amending the commit to add co-authored-by info for @amazy

@floryst floryst added this pull request to the merge queue Jan 28, 2025
Merged via the queue into Kitware:main with commit a814b9b Jan 28, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow VolView to be hosted at non-root url
2 participants