From d7bd5621acc218907b55dfa7a9add366fb2d9279 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?H=C3=A9cate=20Moonlight?= Date: Fri, 26 Jan 2024 10:03:03 +0100 Subject: [PATCH] Add -Wunused-packages to the packages Cabal, Cabal-syntax, cabal-install, cabal-install-solver --- Cabal-syntax/Cabal-syntax.cabal | 3 +++ Cabal/Cabal.cabal | 5 ++++- cabal-install-solver/cabal-install-solver.cabal | 2 ++ cabal-install/cabal-install.cabal | 7 ++++++- 4 files changed, 15 insertions(+), 2 deletions(-) diff --git a/Cabal-syntax/Cabal-syntax.cabal b/Cabal-syntax/Cabal-syntax.cabal index bf1f9e3fcfe..c98a50f1628 100644 --- a/Cabal-syntax/Cabal-syntax.cabal +++ b/Cabal-syntax/Cabal-syntax.cabal @@ -58,6 +58,9 @@ library if impl(ghc >= 8.0) && impl(ghc < 8.8) ghc-options: -Wnoncanonical-monadfail-instances + if impl(ghc >= 8.10) + ghc-options: -Wunused-packages + build-tool-depends: alex:alex exposed-modules: diff --git a/Cabal/Cabal.cabal b/Cabal/Cabal.cabal index e6187ce9a18..5583382181d 100644 --- a/Cabal/Cabal.cabal +++ b/Cabal/Cabal.cabal @@ -51,7 +51,7 @@ library else build-depends: unix >= 2.6.0.0 && < 2.9 - ghc-options: -Wall -fno-ignore-asserts -fwarn-tabs -fwarn-incomplete-uni-patterns -fwarn-incomplete-record-updates + ghc-options: -Wall -fno-ignore-asserts -fwarn-tabs -fwarn-incomplete-uni-patterns -fwarn-incomplete-record-updates -Wunused-packages if impl(ghc >= 8.0) ghc-options: -Wcompat -Wnoncanonical-monad-instances @@ -59,6 +59,9 @@ library if impl(ghc >= 8.0) && impl(ghc < 8.8) ghc-options: -Wnoncanonical-monadfail-instances + if impl(ghc >= 8.10) + ghc-options: -Wunused-packages + exposed-modules: Distribution.Backpack.Configure Distribution.Backpack.ComponentsGraph diff --git a/cabal-install-solver/cabal-install-solver.cabal b/cabal-install-solver/cabal-install-solver.cabal index fe440a78963..3382d666db4 100644 --- a/cabal-install-solver/cabal-install-solver.cabal +++ b/cabal-install-solver/cabal-install-solver.cabal @@ -39,9 +39,11 @@ library ghc-options: -Wall -Wcompat -Wnoncanonical-monad-instances -fwarn-tabs -fwarn-incomplete-uni-patterns + -WUnused-packages if impl(ghc <8.8) ghc-options: -Wnoncanonical-monadfail-instances + if impl(ghc >=8.10) ghc-options: -Wunused-packages diff --git a/cabal-install/cabal-install.cabal b/cabal-install/cabal-install.cabal index f842d4d3157..041f2bf52c0 100644 --- a/cabal-install/cabal-install.cabal +++ b/cabal-install/cabal-install.cabal @@ -39,9 +39,14 @@ Flag lukko manual: True common warnings - ghc-options: -Wall -Wcompat -Wnoncanonical-monad-instances -Wincomplete-uni-patterns -Wincomplete-record-updates + ghc-options: -Wall -Wcompat -Wnoncanonical-monad-instances -Wincomplete-uni-patterns -Wincomplete-record-updates -Wunused-packages + if impl(ghc < 8.8) ghc-options: -Wnoncanonical-monadfail-instances + + if impl(ghc >= 8.10) + ghc-options: -Wunused-packages + if impl(ghc >=9.0) -- Warning: even though introduced with GHC 8.10, -Wunused-packages -- gives false positives with GHC 8.10.