Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests and Python 3.13 #213

Open
fabaff opened this issue Jan 7, 2025 · 1 comment
Open

Tests and Python 3.13 #213

fabaff opened this issue Jan 7, 2025 · 1 comment

Comments

@fabaff
Copy link

fabaff commented Jan 7, 2025

A bunch of tests don't pass anymore on Python 3.13.

============================= test session starts ==============================
platform linux -- Python 3.13.1, pytest-8.3.3, pluggy-1.5.0
rootdir: /build/dominate-2.9.1
configfile: pyproject.toml
collected 65 items

tests/test_document.py .......                                           [ 10%]
tests/test_dom1core.py ...                                               [ 15%]
tests/test_dom_tag.py ........                                           [ 27%]
tests/test_dom_tag_async.py .                                            [ 29%]
tests/test_dominate.py .                                                 [ 30%]
tests/test_html.py ........................                              [ 67%]
tests/test_svg.py FFFFFFF.FFFFFFF                                        [ 90%]
tests/test_utils.py ......                                               [100%]

=================================== FAILURES ===================================
_________________________________ test_animate _________________________________

    def wrapper():
      with base() as result:
        func()
>     assert result.render() == get_expected(func)
E     assert '<svg height=...rect>\n</svg>' == '<svg height=...rect>\n</svg>'
E
E       Skipping 135 identical leading characters in diff, use -v to show
E         9/xlink">
E       - <rect height="100" width="100" x="10" y="10">
E       +   <rect height="100" width="100" x="10" y="10">
E       ? ++
E       -   <animate attributeName="x" attributeType="XML" dur="10s" from="-100" repeatCount="indefinite" to="120"></animate>...
E
E       ...Full output truncated (6 lines hidden), use '-vv' to show

tests/test_svg.py:24: AssertionError
_____________________________ test_animate_motion ______________________________

    def wrapper():
      with base() as result:
        func()
>     assert result.render() == get_expected(func)
E     assert '<svg height=...rcle>\n</svg>' == '<svg height=...rcle>\n</svg>'
E
E       Skipping 135 identical leading characters in diff, use -v to show
E         9/xlink">
E       - <path d="M10,110 A120,120 -45 0,1 110 10 A120,120 -45 0,1 10,110" fill="none" id="theMotionPath" stroke="lightgrey" stroke-width="2"></path>
E       +   <path d="M10,110 A120,120 -45 0,1 110 10 A120,120 -45 0,1 10,110" fill="none" id="theMotionPath" stroke="lightgrey" stroke-width="2"></path>
E       ? ++
E       - <circle cx="10" cy="110" fill="lightgrey" r="3"></circle>...
E
E       ...Full output truncated (21 lines hidden), use '-vv' to show

tests/test_svg.py:24: AssertionError
____________________________ test_animate_transform ____________________________

    def wrapper():
      with base() as result:
        func()
>     assert result.render() == get_expected(func)
E     assert '<svg height=...ygon>\n</svg>' == '<svg height=...ygon>\n</svg>'
E
E       Skipping 135 identical leading characters in diff, use -v to show
E         9/xlink">
E       - <polygon points="60,30 90,90, 30,90">
E       +   <polygon points="60,30 90,90, 30,90">
E       ? ++
E       -   <animateTransform attributeName="transform" attributeType="XML" dur="10s" from="0 60 70" repeatCount="indefinite" to="360 60 70" type="rotate">...
E
E       ...Full output truncated (6 lines hidden), use '-vv' to show

tests/test_svg.py:24: AssertionError
[...]
@Knio
Copy link
Owner

Knio commented Jan 7, 2025

This should already be fixed in master, can you confirm?

https://github.com/Knio/dominate/actions/runs/12554836918/job/35004095366

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants